History: Reduce visual importance of the domain in entries.

History: Reduce visual importance of the domain in entries.

Make the domain gray, and move it to the right of the title so that
all titles are left aligned. Also get rid of the fade-in when entries
are hovered, because it makes the page feel laggy.

BUG=105425
TEST=Manual test of functionality on chrome://history.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112679

[Patrick Dubroy, 2011-11-25 09:39:08]

Hi Jochen,

Can you please review these history changes? They were made in response to
feedback from the UI leads.

[jochen (gone - plz use gerrit), 2011-11-25 09:47:04]

lgtm

[commit-bot: I haz the power, 2011-11-25 12:02:27]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dubroy@chromium.org/8658006/1

[commit-bot: I haz the power, 2011-11-25 12:02:29]

Presubmit check for 8658006-1 failed and returned exit status 1.

Running presubmit commit checks ...

** Presubmit Messages **
If this change has an associated bug, add BUG=[bug number].

** Presubmit ERRORS **
Missing LGTM from an OWNER for:
chrome/browser/resources/history.html,chrome/browser/resources/history.js

[Patrick Dubroy, 2011-11-25 12:37:15]

Evan, can you please review?

[Patrick Dubroy, 2011-11-29 18:02:47]

estade: ping.

[Evan Stade, 2011-11-30 04:46:18]

sorry, holiday backlog

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
File chrome/browser/resources/history.html (right):

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
chrome/browser/resources/history.html:29: #results-separator {
can you move the css into a separate file

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
File chrome/browser/resources/history.js (left):

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
chrome/browser/resources/history.js:987: var link =
checkbox.parentNode.parentNode.parentNode.querySelector('a');
this parentnode chain is super unfortunate code

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
File chrome/browser/resources/history.js (right):

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
chrome/browser/resources/history.js:224: node.style['background-image'] =
node.style.backgroundImage =

[Patrick Dubroy, 2011-12-01 16:23:47]

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
File chrome/browser/resources/history.html (right):

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
chrome/browser/resources/history.html:29: #results-separator {
On 2011/11/30 04:46:18, Evan Stade wrote:
> can you move the css into a separate file

Done.

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
File chrome/browser/resources/history.js (left):

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
chrome/browser/resources/history.js:987: var link =
checkbox.parentNode.parentNode.parentNode.querySelector('a');
On 2011/11/30 04:46:18, Evan Stade wrote:
> this parentnode chain is super unfortunate code

Agreed. I did it in a slightly different way in my new patch -- do you like it
better?

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
File chrome/browser/resources/history.js (right):

http://codereview.chromium.org/8658006/diff/1/chrome/browser/resources/histor...
chrome/browser/resources/history.js:224: node.style['background-image'] =
On 2011/11/30 04:46:18, Evan Stade wrote:
> node.style.backgroundImage =

Done.

[Evan Stade, 2011-12-01 19:43:32]

lgtm

http://codereview.chromium.org/8658006/diff/9003/chrome/browser/resources/his...
File chrome/browser/resources/history.css (right):

http://codereview.chromium.org/8658006/diff/9003/chrome/browser/resources/his...
chrome/browser/resources/history.css:79: /* The box should be no bigger than its
parent. NB: For this to work, the
that's not quite true, you can change the box-sizing property to affect whether
padding and border is included in the width

http://codereview.chromium.org/8658006/diff/9003/chrome/browser/resources/his...
chrome/browser/resources/history.css:112: border: 1px solid hsl(214, 91%, 85%);
you should probably read the CSS style guide section on colors (even if you
already have done so, as we recently discussed it and made some changes).

http://www.chromium.org/developers/web-development-style-guide

You don't need to change all uses of color in this file at this point (although
I certainly wouldn't complain if you did), but it's good to be aware that hsl is
frowned upon.

http://codereview.chromium.org/8658006/diff/9003/chrome/browser/resources/his...
chrome/browser/resources/history.css:137: color:#9a9a9a;
space

http://codereview.chromium.org/8658006/diff/9003/chrome/browser/resources/his...
chrome/browser/resources/history.css:173: }
newline

http://codereview.chromium.org/8658006/diff/9003/chrome/browser/resources/his...
File chrome/browser/resources/history.js (right):

http://codereview.chromium.org/8658006/diff/9003/chrome/browser/resources/his...
chrome/browser/resources/history.js:990: var link =
findAncestorWithClass(checkbox, 'entry-box').querySelector('a');
thumbsup

[commit-bot: I haz the power, 2011-12-02 11:21:49]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/dubroy@chromium.org/8658006/13004

[commit-bot: I haz the power, 2011-12-02 12:55:24]

Change committed as 112679