Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(332)

Unified Diff: chrome/test/ui/ppapi_uitest.cc

Issue 8658004: ASAN failing tests on PPAPITest.* (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/ui/ppapi_uitest.cc
diff --git a/chrome/test/ui/ppapi_uitest.cc b/chrome/test/ui/ppapi_uitest.cc
index 069df4f2281014328dbd13f093224d9c72ccdaa4..ae83261d8856291c92754e6800fb993a8e23d54c 100644
--- a/chrome/test/ui/ppapi_uitest.cc
+++ b/chrome/test/ui/ppapi_uitest.cc
@@ -231,6 +231,11 @@ class PPAPINaClTest : public PPAPITestBase {
// Interface tests.
//
+// Disable tests under ASAN. http://crbug.com/104832.
+// This is a bit heavy handed, but the majority of these tests fail under ASAN.
+// See bug for history.
+#if !defined(ADDRESS_SANITIZER)
+
TEST_PPAPI_IN_PROCESS(Broker)
TEST_PPAPI_OUT_OF_PROCESS(Broker)
@@ -446,3 +451,5 @@ TEST_PPAPI_OUT_OF_PROCESS(Flash_GetCommandLineArgs)
TEST_PPAPI_IN_PROCESS(WebSocket_Create)
TEST_PPAPI_IN_PROCESS(WebSocket_IsWebSocket)
+
+#endif // ADDRESS_SANITIZER
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698