Issue 8658004: ASAN failing tests on PPAPITest.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8658004: ASAN failing tests on PPAPITest.* (Closed)

Created:
9 years, 1 month ago by dhollowa

Modified:
9 years, 1 month ago

Reviewers:
Alexander Potapenko, noelallen_use_chromium

CC:
chromium-reviews, Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

ASAN failing tests on PPAPITest.* Disables ALL PPAPITest.* tests under ASAN. Increasing timeouts and selective per-test disablement did not work. So ifdef'ing out the whole bunch under ASAN. BUG=104832 TEST=ASAN bot runs green TBR=glider@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111238

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -0 lines)			Patch
	M	chrome/test/ui/ppapi_uitest.cc	View		2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

dhollowa

I pulled out my other attempts and have disabled all of these under ASAN. Wondering ...

9 years, 1 month ago (2011-11-22 22:46:28 UTC) #1

noelallen_use_chromium

The change LGTM but why didn't the exclude work? http://codereview.chromium.org/8585003/diff/12001/tools/valgrind/gtest_exclude/ui_tests.gtest.txt

9 years, 1 month ago (2011-11-22 23:44:30 UTC) #2

Alexander Potapenko

9 years, 1 month ago (2011-11-23 10:58:51 UTC) #3

Currently the ASan bots do not use any wrappers to run the tests, thus it's hard
to pass any additional arguments to them.
The script in tools/valgrind/chrome_tests.sh allows running ASan tests
(--tool=asan) and use the gtest filters, but we were trying hard to keep the
testing process simple and avoid using the wrappers.

Expand Messages | Collapse Messages