Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 8658002: Print preview: Enable tests that were previous excluded on CrOS. (Closed)

Created:
9 years, 1 month ago by Lei Zhang
Modified:
9 years, 1 month ago
Reviewers:
kmadhusu
CC:
chromium-reviews
Visibility:
Public.

Description

Print preview: Eanble tests that were previous excluded on CrOS. Disable tests on Aura as needed. BUG=105186 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111304

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -21 lines) Patch
M chrome/browser/printing/print_preview_tab_controller_unittest.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_handler_unittest.cc View 1 5 chunks +11 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/print_preview_ui_unittest.cc View 1 3 chunks +7 lines, -3 lines 0 comments Download
M chrome/chrome_tests.gypi View 3 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Lei Zhang
they passed locally for me
9 years, 1 month ago (2011-11-22 21:59:39 UTC) #1
kmadhusu
lgtm
9 years, 1 month ago (2011-11-22 22:10:48 UTC) #2
Lei Zhang
Needed to disable tests on Aura.
9 years, 1 month ago (2011-11-22 23:25:54 UTC) #3
kmadhusu
lgtm
9 years, 1 month ago (2011-11-22 23:32:54 UTC) #4
kmadhusu
Please update the description.
9 years, 1 month ago (2011-11-22 23:33:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/8658002/4001
9 years, 1 month ago (2011-11-23 01:32:43 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 03:31:27 UTC) #7
Change committed as 111304

Powered by Google App Engine
This is Rietveld 408576698