Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(313)

Issue 8657: Check the growth of the old generation before expanding the paged... (Closed)

Created:
12 years, 1 month ago by Kevin Millikin (Chromium)
Modified:
9 years, 7 months ago
Reviewers:
bak, Kasper Lund
CC:
v8-dev
Visibility:
Public.

Description

Check the growth of the old generation before expanding the paged spaces (during normal allocation) and when allocating large objects. If the promotion limit is reached, fail allocation to trigger a garbage collection. Committed: http://code.google.com/p/v8/source/detail?r=632

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -13 lines) Patch
M src/heap.h View 1 2 chunks +23 lines, -2 lines 0 comments Download
M src/heap.cc View 1 4 chunks +14 lines, -7 lines 0 comments Download
M src/spaces.cc View 1 3 chunks +23 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Kevin Millikin (Chromium)
I'm running it paa robotten to see if there's any performance impact.
12 years, 1 month ago (2008-10-28 13:36:48 UTC) #1
bak
Hi Kevin I think we need a different limit for triggering GC when too much ...
12 years, 1 month ago (2008-10-29 07:39:30 UTC) #2
Kevin Millikin (Chromium)
New policy, avoids hitting bad case on benchmarks. Take a look?
12 years, 1 month ago (2008-10-29 09:07:54 UTC) #3
bak
12 years, 1 month ago (2008-10-29 09:24:46 UTC) #4
LGTM,
  Lars

Powered by Google App Engine
This is Rietveld 408576698