Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1206)

Unified Diff: chrome/browser/extensions/chrome_app_api_browsertest.cc

Issue 8654001: Reland restrict extension features based on the extension type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/chrome_app_api_browsertest.cc
diff --git a/chrome/browser/extensions/chrome_app_api_browsertest.cc b/chrome/browser/extensions/chrome_app_api_browsertest.cc
index 0f5219e081f81995076c9673f0e87820d784757f..e211fbc96ad22fc99e07f715c9bf3477ba962a70 100644
--- a/chrome/browser/extensions/chrome_app_api_browsertest.cc
+++ b/chrome/browser/extensions/chrome_app_api_browsertest.cc
@@ -13,6 +13,7 @@
#include "chrome/browser/ui/browser.h"
#include "chrome/common/chrome_switches.h"
#include "chrome/common/extensions/extension.h"
+#include "chrome/common/extensions/manifest_value.h"
#include "chrome/test/base/ui_test_utils.h"
#include "content/browser/tab_contents/tab_contents.h"
#include "googleurl/src/gurl.h"
@@ -101,7 +102,7 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, IsInstalled) {
// extension->manifest_value() does not contain the id.
app_details->Remove("id", NULL);
EXPECT_TRUE(app_details.get());
- EXPECT_TRUE(app_details->Equals(extension->manifest_value()));
+ EXPECT_TRUE(app_details->Equals(extension->manifest_value()->value()));
// Try to change app.isInstalled. Should silently fail, so
// that isInstalled should have the initial value.
@@ -180,5 +181,5 @@ IN_PROC_BROWSER_TEST_F(ChromeAppAPITest, GetDetailsForFrame) {
// extension->manifest_value() does not contain the id.
app_details->Remove("id", NULL);
EXPECT_TRUE(app_details.get());
- EXPECT_TRUE(app_details->Equals(extension->manifest_value()));
+ EXPECT_TRUE(app_details->Equals(extension->manifest_value()->value()));
}
« no previous file with comments | « no previous file | chrome/browser/extensions/extension_prefs.cc » ('j') | chrome/browser/extensions/extension_prefs.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698