chrome/renderer/extensions/app_bindings.cc - Issue 8654001: Reland restrict extension features based on the extension type.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/renderer/extensions/app_bindings.cc

Issue 8654001: Reland restrict extension features based on the extension type. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/renderer/extensions/app_bindings.cc

diff --git a/chrome/renderer/extensions/app_bindings.cc b/chrome/renderer/extensions/app_bindings.cc

index 8ce96a2590240e687249c585b14a53dee4c2ace1..eaa257308e9d6b77f51c35861c68ea318d7019d9 100644

--- a/chrome/renderer/extensions/app_bindings.cc

+++ b/chrome/renderer/extensions/app_bindings.cc

@@ -12,6 +12,7 @@

#include "chrome/common/chrome_switches.h"

#include "chrome/common/extensions/extension_messages.h"

#include "chrome/common/extensions/extension_set.h"

+#include "chrome/common/extensions/manifest.h"

#include "chrome/renderer/extensions/chrome_v8_context.h"

#include "chrome/renderer/extensions/extension_dispatcher.h"

#include "chrome/renderer/extensions/extension_helper.h"

@@ -193,7 +194,7 @@ v8::Handle<v8::Value> AppBindingsHandler::GetDetailsForFrameImpl(

return v8::Null();

scoped_ptr<DictionaryValue> manifest_copy(

- extension->manifest_value()->DeepCopy());

+ extension->manifest()->value()->DeepCopy());

manifest_copy->SetString("id", extension->id());

scoped_ptr<V8ValueConverter> converter(V8ValueConverter::create());

return converter->ToV8Value(manifest_copy.get(),