Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(878)

Unified Diff: base/threading/worker_pool_unittest.cc

Issue 8653006: Remove custom Task implementations in base. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/worker_pool_unittest.cc
diff --git a/base/threading/worker_pool_unittest.cc b/base/threading/worker_pool_unittest.cc
index cd20f478044fdc42c2e89020a34cc0722c54d6e8..1ecbaf7b9ed240b2c9c323d49fd944ef1bbc4802 100644
--- a/base/threading/worker_pool_unittest.cc
+++ b/base/threading/worker_pool_unittest.cc
@@ -21,18 +21,9 @@ namespace base {
namespace {
-class PostTaskTestTask : public Task {
- public:
- explicit PostTaskTestTask(WaitableEvent* event) : event_(event) {
- }
-
- void Run() {
- event_->Signal();
- }
-
- private:
- WaitableEvent* event_;
-};
+void PostTaskTestHelper(WaitableEvent* event) {
willchan no longer on Chromium 2011/11/23 18:15:46 Why is this wrapper function necessary?
dcheng 2011/11/23 18:47:49 Done.
+ event->Signal();
+}
class PostTaskAndReplyTester
: public base::RefCountedThreadSafe<PostTaskAndReplyTester> {
@@ -81,8 +72,12 @@ TEST_F(WorkerPoolTest, PostTask) {
WaitableEvent test_event(false, false);
WaitableEvent long_test_event(false, false);
- WorkerPool::PostTask(FROM_HERE, new PostTaskTestTask(&test_event), false);
- WorkerPool::PostTask(FROM_HERE, new PostTaskTestTask(&long_test_event), true);
+ WorkerPool::PostTask(FROM_HERE,
+ base::Bind(&PostTaskTestHelper, &test_event),
+ false);
+ WorkerPool::PostTask(FROM_HERE,
+ base::Bind(&PostTaskTestHelper, &long_test_event),
+ true);
test_event.Wait();
long_test_event.Wait();
« base/synchronization/waitable_event_watcher_posix.cc ('K') | « base/threading/thread_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698