Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 8653004: Fix python scripts in src/ppapi/ (Closed)

Created:
9 years, 1 month ago by M-A Ruel
Modified:
8 years, 11 months ago
CC:
chromium-reviews, pam+watch_chromium.org, piman+watch_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, ihf+watch_chromium.org
Visibility:
Public.

Description

Fix python scripts in src/ppapi/ Make sure that: - shebang is only present for executable files - shebang is #!/usr/bin/env python - __main__ is only present for executable files - file's executable bit is coherent Also fix EOF LF to be only one. Minor python style fixes. TBR=noelallen BUG=105108 TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=117045

Patch Set 1 #

Patch Set 2 : Rebase against HEAD #

Patch Set 3 : rebased #

Patch Set 4 : rebase error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -99 lines) Patch
M ppapi/generate_ppapi_include_tests.py View 2 chunks +12 lines, -12 lines 0 comments Download
M ppapi/generate_ppapi_size_checks.py View 6 chunks +15 lines, -23 lines 0 comments Download
M ppapi/generators/generator.py View 1 2 chunks +10 lines, -10 lines 0 comments Download
M ppapi/generators/idl_ast.py View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/generators/idl_c_header.py View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M ppapi/generators/idl_c_proto.py View 1 2 3 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/generators/idl_diff.py View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/generators/idl_generator.py View 1 1 chunk +1 line, -2 lines 0 comments Download
M ppapi/generators/idl_lexer.py View 3 chunks +2 lines, -4 lines 0 comments Download
M ppapi/generators/idl_lint.py View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/generators/idl_log.py View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/generators/idl_namespace.py View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/generators/idl_node.py View 2 chunks +2 lines, -3 lines 0 comments Download
M ppapi/generators/idl_option.py View 2 chunks +0 lines, -3 lines 0 comments Download
M ppapi/generators/idl_outfile.py View 1 2 4 chunks +8 lines, -4 lines 0 comments Download
M ppapi/generators/idl_parser.py View 1 2 3 chunks +3 lines, -2 lines 0 comments Download
M ppapi/generators/idl_propertynode.py View 3 chunks +3 lines, -3 lines 0 comments Download
M ppapi/generators/idl_release.py View 6 chunks +6 lines, -3 lines 0 comments Download
M ppapi/generators/idl_visitor.py View 2 chunks +0 lines, -4 lines 0 comments Download
M ppapi/native_client/src/tools/srpcgen.py View 1 2 2 chunks +1 line, -4 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
M-A Ruel
Context: I'm going to add a presubmit check to enforce some of these rules.
9 years, 1 month ago (2011-11-23 02:08:34 UTC) #1
noelallen_use_chromium
LGTM
9 years, 1 month ago (2011-11-23 02:10:57 UTC) #2
M-A Ruel
On 2011/11/23 02:10:57, noelallen wrote: > LGTM Note: I'll mark it as TBR because of ...
9 years, 1 month ago (2011-11-23 02:12:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8653004/1
9 years, 1 month ago (2011-11-23 17:55:03 UTC) #4
commit-bot: I haz the power
Try job failure for 8653004-1 (retry) (previous was lost) on mac_rel for step "media_unittests". It's ...
9 years, 1 month ago (2011-11-23 20:30:33 UTC) #5
noelallen1
You may want to resubmit this. LGTM
9 years ago (2011-12-01 18:00:54 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/8653004/14002
8 years, 11 months ago (2012-01-10 16:33:05 UTC) #7
commit-bot: I haz the power
8 years, 11 months ago (2012-01-10 17:47:02 UTC) #8
Change committed as 117045

Powered by Google App Engine
This is Rietveld 408576698