Issue 8652002: Move PropertyBag to base. Originally this was in chrome\common because only chrome used it. Now t...

Issue 8652002: Move PropertyBag to base. Originally this was in chrome\common because only chrome used it. Now t... (Closed)

Created:
9 years, 1 month ago by jam

Modified:
9 years, 1 month ago

Reviewers:
willchan no longer on Chromium

CC:
chromium-reviews, Avi (use Gerrit), creis+watch_chromium.org, Erik does not do reviews, ajwong+watch_chromium.org, jam, mihaip+watch_chromium.org, dpranke-watch+content_chromium.org, joi+watch-content_chromium.org, Aaron Boodman, Paweł Hajdan Jr., darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Move PropertyBag to base. Originally this was in chrome\common because only chrome used it. Now that chrome and content use it, and that we want to only expose interface through the content API, this belongs in base. BUG=98716 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111266

Patch Set 1 #

Patch Set 2 : move to base namespace and forward declare where possible #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+77 lines, -347 lines)			Patch
M	base/base.gyp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	base/base.gypi	View		1 chunk	+2 lines, -0 lines	0 comments	Download
A +	base/property_bag.h	View	1	4 chunks	+12 lines, -8 lines	0 comments	Download
A +	base/property_bag.cc	View	1	2 chunks	+6 lines, -1 line	0 comments	Download
A +	base/property_bag_unittest.cc	View	1	2 chunks	+5 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_omnibox_api.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.h	View	1	4 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/extensions/extension_service.cc	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
M	chrome/browser/tabs/tab_strip_model_unittest.cc	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/gtk/omnibox/omnibox_view_gtk.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.h	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.cc	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/views/omnibox/omnibox_view_win.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/constrained_html_ui.h	View	1	3 chunks	+5 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/constrained_html_ui.cc	View	1	3 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/html_dialog_ui.h	View	1	2 chunks	+6 lines, -6 lines	0 comments	Download
M	chrome/browser/ui/webui/html_dialog_ui.cc	View	1	3 chunks	+4 lines, -2 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host.h	View	1	3 chunks	+4 lines, -4 lines	0 comments	Download
M	content/browser/tab_contents/tab_contents.h	View	1	4 chunks	+4 lines, -4 lines	0 comments	Download
D	content/common/property_bag.h	View		1 chunk	+0 lines, -176 lines	0 comments	Download
D	content/common/property_bag.cc	View		1 chunk	+0 lines, -56 lines	0 comments	Download
D	content/common/property_bag_unittest.cc	View		1 chunk	+0 lines, -62 lines	0 comments	Download
M	content/content_common.gypi	View		1 chunk	+0 lines, -2 lines	0 comments	Download
M	content/content_tests.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

9 years, 1 month ago (2011-11-22 22:00:49 UTC) #2

LGTM

It's not worth blocking the change on these requests, but if you felt so
inclined, they might be worth doing:
* forward declare the PropertyAccessor template rather than including the header
* move the PropertyBag stuff into the base namespace

Expand Messages | Collapse Messages