Issue 8651006: Remove remaining defined(TOUCH_UI) under views/controls

Issue 8651006: Remove remaining defined(TOUCH_UI) under views/controls (Closed)

Created:
9 years, 1 month ago by Emmanuel Saint-loubert-Bié

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, James Su, yusukes+watch_chromium.org, penghuang+watch_chromium.org, dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Remove remaining defined(TOUCH_UI) under views/controls BUG=105046 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111272

Patch Set 1 #

Total comments: 2

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -31 lines)			Patch
	M	views/controls/menu/menu_controller.cc	View		2 chunks	+1 line, -17 lines	2 comments	Download
	M	views/controls/textfield/native_textfield_views.cc	View		2 chunks	+1 line, -14 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/8651006/diff/1/views/controls/menu/menu_controller.cc File views/controls/menu/menu_controller.cc (left): http://codereview.chromium.org/8651006/diff/1/views/controls/menu/menu_controller.cc#oldcode921 views/controls/menu/menu_controller.cc:921: base::MessagePumpDispatcher::DispatchStatus Does the header need to be updated too?

9 years, 1 month ago (2011-11-22 22:39:18 UTC) #2

Emmanuel Saint-loubert-Bié

I agree this is weird, but this is correct (which means it was probably broken ...

9 years, 1 month ago (2011-11-22 22:42:38 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/saintlou@chromium.org/8651006/1

9 years, 1 month ago (2011-11-22 23:04:15 UTC) #5

Change committed as 111272

Expand Messages | Collapse Messages