Issue 865002: Add SSE2 instructions to disassembler and movmskpd SSE2 instruction to assemb...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 865002: Add SSE2 instructions to disassembler and movmskpd SSE2 instruction to assemb... (Closed)

Created:
10 years, 9 months ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Rico

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add SSE2 instructions to disassembler and movmskpd SSE2 instruction to assembler. Committed: http://code.google.com/p/v8/source/detail?r=4110

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 10 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+67 lines, -11 lines)			Patch
M	src/ia32/assembler-ia32.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/ia32/assembler-ia32.cc	View		2 chunks	+16 lines, -0 lines	0 comments	Download
M	src/ia32/disasm-ia32.cc	View	1	3 chunks	+49 lines, -10 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ricowindcs_gmail.com

10 years, 9 months ago (2010-03-11 18:20:04 UTC) #2

LGMT

http://codereview.chromium.org/865002/diff/5001/6003
File src/ia32/disasm-ia32.cc (right):

http://codereview.chromium.org/865002/diff/5001/6003#newcode1257
src/ia32/disasm-ia32.cc:1257: }
The conditionals above could potentially be made more compact by letting the
"else if" be the "if" and combining the two others with just the second
AppendToBuffer being dependent on b2 - but this might make this less readable.

Expand Messages | Collapse Messages