Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6)

Issue 865001: Merge 34145 - Reverts my r4300 and refixes Issue 3156 and 13500.... (Closed)

Created:
10 years, 9 months ago by tkent
Modified:
9 years, 7 months ago
Reviewers:
Hironori Bono
CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org
Visibility:
Public.

Description

Merge 34145 - Reverts my r4300 and refixes Issue 3156 and 13500. My r4300, which is a fix Issue 3156, has been causing regressions (Issue 9596, Issue 13500, Issue 29290, etc.) Every time when this change caused regressions, we added more code to Chromium and made Chromium code more complicated. So, I think it is better to revert this change once and find another solution for Issue 3156 rather than to add another workaround for Issue 29290. To look into Issue 3156 more deeply, it is caused by a recursive messagehandler call. When SetWindowText() is called while an IME is composing text, the IME calls SendMessage() to send a WM_IME_COMPOSITION message. When we receive this WM_IME_COMPOSITION message, it updates the omnibox and calls SetWindowText()... This recursive call caused not only Issue 3156 but also caused some other IME issues, such as Issue 13500. BUG=3156, 13500, 29290 TEST=On XP, open a new tab, set the IME to Hiragana, type 'c', and then click an entry in the popup. The browser should navigate and show the popup URL without a crash. TEST=Open Gmail, compose a new email (without using a tearoff window), set the IME to Hiragana, type 'c' in its message body, and wait for the draft autosaving. The browser should show the 'c' character. Review URL: http://codereview.chromium.org/467015 TBR=hbono@chromium.org BUG=3156, 13500, 29290 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=41254

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -23 lines) Patch
M chrome/browser/autocomplete/autocomplete_edit_view_win.h View 2 chunks +2 lines, -0 lines 0 comments Download
M chrome/browser/autocomplete/autocomplete_edit_view_win.cc View 3 chunks +14 lines, -23 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tkent
10 years, 9 months ago (2010-03-11 06:00:34 UTC) #1
tkent
This is a merge to the 249 branch.
10 years, 9 months ago (2010-03-11 06:01:52 UTC) #2
Hironori Bono
10 years, 9 months ago (2010-03-11 06:30:47 UTC) #3
LGTM.
Thank you for merging this to the 249 branch. I forgot it.

Regards,

Hironori Bono

Powered by Google App Engine
This is Rietveld 408576698