Issue 8650001: Move ChromeOS bubble setup code to window.cc.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8650001: Move ChromeOS bubble setup code to window.cc. (Closed)

Created:
9 years, 1 month ago by msw

Modified:
9 years, 1 month ago

Reviewers:
alicet1, Daniel Erat, Ben Goodger (Google)

CC:
chromium-reviews, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Patch from AliceT's issue codereview.chromium.org/8604012. Move ChromeOS bubble setup code to window.cc. This code is also in the original bubble code. msw: Update name to CreateViewsBubbleAboveLockScreen. BUG=98322 TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111243

Patch Set 1 #

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+64 lines, -27 lines)			Patch
M	chrome/browser/chromeos/setting_level_bubble.cc	View	2 chunks	+2 lines, -18 lines	0 comments	Download
M	chrome/browser/speech/speech_input_bubble_views.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/avatar_menu_button.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/bookmarks/bookmark_bubble_view.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/first_run_bubble.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/global_error_bubble_view.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/location_bar/content_setting_image_view.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/page_info_bubble_view.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/toolbar_view.cc	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/browser/ui/views/window.h	View	2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/ui/views/window.cc	View	2 chunks	+35 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

msw

Addressing comment from http://codereview.chromium.org/8604012/

9 years, 1 month ago (2011-11-22 20:52:02 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/msw@chromium.org/8650001/1

9 years, 1 month ago (2011-11-22 21:13:09 UTC) #4

Change committed as 111243

Expand Messages | Collapse Messages