Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8649007: Reland "Move a bunch of ChromeOS APIs out of chrome/browser/extensions."" (Closed)

Created:
9 years, 1 month ago by Aaron Boodman
Modified:
9 years ago
Reviewers:
James Cook
CC:
chromium-reviews, asanka, vrk (LEFT CHROMIUM), nkostylev+watch_chromium.org, achuith+watch_chromium.org, mihaip+watch_chromium.org, rginda+watch_chromium.org, ajwong+watch_chromium.org, stevenjb+watch_chromium.org, Erik does not do reviews, acolwell+watch_chromium.org, brettw-cc_chromium.org, ihf+watch_chromium.org, Avi (use Gerrit), creis+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, Randy Smith (Not in Mondays), annacc+watch_chromium.org, arv (Not doing code reviews), scherkus (not reviewing), hclam+watch_chromium.org, Aaron Boodman, Paweł Hajdan Jr., davemoore+watch_chromium.org
Visibility:
Public.

Description

Reland "Move a bunch of ChromeOS APIs out of chrome/browser/extensions."" Original CL: http://codereview.chromium.org/8609008 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111661

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -4093 lines) Patch
M build/common.gypi View 1 chunk +2 lines, -2 lines 1 comment Download
M chrome/browser/chromeos/extensions/file_browser_event_router.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/extensions/file_browser_extension_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_browser_extension_api.cc View 2 chunks +2 lines, -2 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_browser_extension_apitest.cc View 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager_util.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/extensions/file_manager_util.cc View 2 chunks +1 line, -2 lines 0 comments Download
A + chrome/browser/chromeos/extensions/get_chromeos_info_extension_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/extensions/get_chromeos_info_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/extensions/get_chromeos_info_extension_apitest.cc View 1 chunk +1 line, -0 lines 0 comments Download
A + chrome/browser/chromeos/extensions/input_ime_extension_api.h View 5 chunks +9 lines, -9 lines 0 comments Download
A + chrome/browser/chromeos/extensions/input_ime_extension_api.cc View 16 chunks +22 lines, -22 lines 0 comments Download
A + chrome/browser/chromeos/extensions/input_ime_extension_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/extensions/input_method_extension_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/extensions/input_method_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/chromeos/extensions/input_method_extension_apitest.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
A + chrome/browser/chromeos/extensions/media_player_extension_api.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/chromeos/extensions/media_player_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/media/media_player.cc View 1 chunk +1 line, -1 line 0 comments Download
D chrome/browser/extensions/extension_file_browser_private_api.h View 1 chunk +0 lines, -363 lines 0 comments Download
D chrome/browser/extensions/extension_file_browser_private_api.cc View 1 chunk +0 lines, -1684 lines 0 comments Download
D chrome/browser/extensions/extension_file_browser_private_apitest.cc View 1 chunk +0 lines, -139 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 chunk +5 lines, -5 lines 0 comments Download
D chrome/browser/extensions/extension_info_private_api_chromeos.h View 1 chunk +0 lines, -27 lines 0 comments Download
D chrome/browser/extensions/extension_info_private_api_chromeos.cc View 1 chunk +0 lines, -71 lines 0 comments Download
D chrome/browser/extensions/extension_info_private_apitest_chromeos.cc View 1 chunk +0 lines, -8 lines 0 comments Download
D chrome/browser/extensions/extension_input_ime_api.h View 1 chunk +0 lines, -133 lines 0 comments Download
D chrome/browser/extensions/extension_input_ime_api.cc View 1 chunk +0 lines, -860 lines 0 comments Download
D chrome/browser/extensions/extension_input_ime_apitest.cc View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/extensions/extension_input_method_api.h View 1 chunk +0 lines, -25 lines 0 comments Download
D chrome/browser/extensions/extension_input_method_api.cc View 1 chunk +0 lines, -43 lines 0 comments Download
D chrome/browser/extensions/extension_input_method_apitest.cc View 1 chunk +0 lines, -69 lines 0 comments Download
D chrome/browser/extensions/extension_mediaplayer_private_api.h View 1 chunk +0 lines, -57 lines 0 comments Download
D chrome/browser/extensions/extension_mediaplayer_private_api.cc View 1 chunk +0 lines, -76 lines 0 comments Download
M chrome/browser/extensions/extension_service.cc View 4 chunks +3 lines, -4 lines 0 comments Download
D chrome/browser/extensions/file_manager_util.h View 1 chunk +0 lines, -56 lines 0 comments Download
D chrome/browser/extensions/file_manager_util.cc View 1 chunk +0 lines, -348 lines 0 comments Download
M chrome/browser/platform_util_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/file_manager/js/mock_chrome.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/tab_contents/render_view_context_menu.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/browser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/select_file_dialog_aura.cc View 2 chunks +1 line, -5 lines 0 comments Download
M chrome/browser/ui/views/select_file_dialog_extension.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/active_downloads_ui.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/downloads_dom_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 10 chunks +30 lines, -29 lines 0 comments Download
M chrome/chrome_tests.gypi View 4 chunks +6 lines, -6 lines 0 comments Download
M chrome/test/data/extensions/api_test/filebrowser_mount/test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Aaron Boodman
The only changes from the original are: - turned off file manager in common.gypi for ...
9 years, 1 month ago (2011-11-22 22:00:04 UTC) #1
James Cook
9 years, 1 month ago (2011-11-22 22:20:42 UTC) #2 
LGTM with one comment.  Thanks for standardizing all the file names and class
names - consistent names make everyone's life easier.

http://codereview.chromium.org/8649007/diff/1/build/common.gypi
File build/common.gypi (right):

http://codereview.chromium.org/8649007/diff/1/build/common.gypi#newcode318
build/common.gypi:318: # ... except on Windows even with Aura.
Delete this block?

Powered by Google App Engine
This is Rietveld 408576698