chrome/test/functional/chromeos_security.py - Issue 8649004: Allow chromedriver to install an extension and get all installed extension IDs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/functional/chromeos_security.py

Issue 8649004: Allow chromedriver to install an extension and get all installed extension IDs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: bind Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/test/automation/automation_json_requests.cc ('k') | chrome/test/functional/chromoting_basic.py » ('j') | chrome/test/webdriver/commands/chrome_commands.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/functional/chromeos_security.py

diff --git a/chrome/test/functional/chromeos_security.py b/chrome/test/functional/chromeos_security.py

index 40be9f6e9d5be65365886aafd0790ec77d2b9238..2bf561f97c3bab16bb2267d41c2ee973ec98b9c6 100644

--- a/chrome/test/functional/chromeos_security.py

+++ b/chrome/test/functional/chromeos_security.py

@@ -154,7 +154,7 @@ class ChromeosSecurity(pyauto.PyUITest):

expected_names = [ext['name'] for ext in self._component_extension_baseline]

ext_actual_info = self.GetExtensionsInfo()

actual_names = [ext['name'] for ext in ext_actual_info if

- ext['is_component_extension']]

+ ext['is_component']]

self._AssertExtensionNamesAreExpected(

set(expected_names), set(actual_names), 'Component extension',

self._component_extension_baseline, ext_actual_info)

@@ -169,8 +169,7 @@ class ChromeosSecurity(pyauto.PyUITest):

file_name in [x['crx_file'] for x in self._bundled_crx_baseline],

msg='Unexpected CRX file: ' + file_name)

crx_file = os.path.join(self._bundled_crx_directory, file_name)

- self.assertTrue(self.InstallExtension(crx_file, False),

- msg='Extension install failed: %s' % crx_file)

+ self.InstallExtension(crx_file)

# Verify that the permissions information in the baseline matches the

# permissions associated with the installed bundled CRX extensions.

@@ -182,8 +181,7 @@ class ChromeosSecurity(pyauto.PyUITest):

for file_name in os.listdir(self._bundled_crx_directory):

if file_name.endswith('.crx'):

crx_file = os.path.join(self._bundled_crx_directory, file_name)

- self.assertTrue(self.InstallExtension(crx_file, False),

- msg='Extension install failed: %s' % crx_file)

+ self.InstallExtension(crx_file)

# Ensure that the set of installed extension names precisely matches the

# baseline.