Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(6848)

Unified Diff: chrome/test/functional/themes.py

Issue 8649004: Allow chromedriver to install an extension and get all installed extension IDs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/functional/themes.py
diff --git a/chrome/test/functional/themes.py b/chrome/test/functional/themes.py
index b7189497597ec4502ea702d4558f919adbea9d96..148740de819283e50f2581e5e82a8a59020e7c7f 100644
--- a/chrome/test/functional/themes.py
+++ b/chrome/test/functional/themes.py
@@ -28,7 +28,7 @@ class ThemesTest(pyauto.PyUITest):
self.assertFalse(self.GetThemeInfo()) # Verify there's no theme at startup
crx_file = os.path.abspath(
os.path.join(self.DataDir(), 'extensions', 'theme.crx'))
- self.assertTrue(self.SetTheme(crx_file))
+ self.SetTheme(crx_file)
# Verify "theme installed" infobar shows up
self.assertTrue(self.WaitForInfobarCount(1))
theme = self.GetThemeInfo()
@@ -41,7 +41,7 @@ class ThemesTest(pyauto.PyUITest):
self.assertFalse(self.GetThemeInfo()) # Verify there's no theme at startup
crx_file = os.path.abspath(
os.path.join(self.DataDir(), 'extensions', 'theme.crx'))
- self.assertTrue(self.SetTheme(crx_file))
+ self.SetTheme(crx_file)
# Verify "theme installed" infobar shows up
self.assertTrue(self.WaitForInfobarCount(1))
theme = self.GetThemeInfo()
@@ -51,7 +51,7 @@ class ThemesTest(pyauto.PyUITest):
"""Verify theme reset."""
crx_file = os.path.abspath(
os.path.join(self.DataDir(), 'extensions', 'theme.crx'))
- self.assertTrue(self.SetTheme(crx_file))
+ self.SetTheme(crx_file)
self.assertTrue(self.ResetToDefaultTheme())
self.assertFalse(self.GetThemeInfo())
@@ -78,8 +78,7 @@ class ThemesTest(pyauto.PyUITest):
# Apply each theme in this group.
for theme in this_group:
logging.debug('Applying theme: %s' % theme)
- self.assertTrue(self.SetTheme(theme),
- 'Theme %s not installed.' % theme)
+ self.SetTheme(theme)
for url in urls:
self.NavigateToURL(url)

Powered by Google App Engine
This is Rietveld 408576698