Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: chrome/test/functional/extensions.py

Issue 8649004: Allow chromedriver to install an extension and get all installed extension IDs. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ... Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/functional/extensions.py
diff --git a/chrome/test/functional/extensions.py b/chrome/test/functional/extensions.py
index c949a71d5e3a266a8834852c2dede4cbd659b98d..fefd59420b15679b1b53ae515a01d976a6c3b8c4 100644
--- a/chrome/test/functional/extensions.py
+++ b/chrome/test/functional/extensions.py
@@ -61,7 +61,7 @@ class ExtensionsTest(pyauto.PyUITest):
group_end = curr_extension + group_size
for extension in extensions[curr_extension:group_end]:
logging.debug('Installing extension: %s' % extension)
- self.InstallExtension(extension, False)
+ self.InstallExtension(extension)
for url in top_urls:
self.NavigateToURL(url)
@@ -154,8 +154,7 @@ class ExtensionsTest(pyauto.PyUITest):
"""Test setting different extension states."""
crx_file_path = os.path.abspath(
os.path.join(self.DataDir(), 'extensions', 'google_talk.crx'))
- ext_id = self.InstallExtension(crx_file_path, False);
- self.assertTrue(ext_id, 'Failed to install extension.')
+ ext_id = self.InstallExtension(crx_file_path)
# Verify extension is in default state.
extension = self._GetExtensionInfoById(self.GetExtensionsInfo(), ext_id)
@@ -188,8 +187,7 @@ class ExtensionsTest(pyauto.PyUITest):
"""
crx_file_path = os.path.abspath(
os.path.join(self.DataDir(), 'extensions', 'adblock.crx'))
- ext_id = self.InstallExtension(crx_file_path, False)
- self.assertTrue(ext_id, msg='Failed to install extension.')
+ ext_id = self.InstallExtension(crx_file_path)
self.RestartBrowser(clear_profile=False)
extension = self._GetExtensionInfoById(self.GetExtensionsInfo(), ext_id)

Powered by Google App Engine
This is Rietveld 408576698