Allow chromedriver to install an extension and get all installed extension IDs.

chrome/browser/automation/automation_provider_observers.h

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_OBSERVERS_H_
 #define CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_OBSERVERS_H_
 #pragma once
 
 #include <deque>
 #include <map>
@@ skipping 318 matching lines @@
   std::string id_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionUninstallObserver);
 };
 
 // Observes when an extension has finished loading and is ready for use. Also
 // checks for possible install errors.
 class ExtensionReadyNotificationObserver
     : public content::NotificationObserver {
  public:
+  // Creates an observer that replies using the old IPC automation method.
   ExtensionReadyNotificationObserver(ExtensionProcessManager* manager,

[dennis_jeffrey, 2011/11/22 23:32:16]

Do we still need this old version of the function? Can we get rid of it?

[kkania, 2011/11/23 17:31:23]

Yes, there is an install extension func in automation_provider that uses it.
That func itself is used by a ui test and an old version of chromedriver.

                                      ExtensionService* service,
                                      AutomationProvider* automation,
                                      int id,
                                      IPC::Message* reply_message);
+  // Creates an observer that replies using the JSON automation interface.
+  ExtensionReadyNotificationObserver(ExtensionProcessManager* manager,
+                                     ExtensionService* service,
+                                     AutomationProvider* automation,
+                                     IPC::Message* reply_message);
   virtual ~ExtensionReadyNotificationObserver();
 
   // Implementation of NotificationObserver.
   virtual void Observe(int type,
                        const content::NotificationSource& source,
                        const content::NotificationDetails& details);
 
  private:
+  void Init();
+
   content::NotificationRegistrar registrar_;
   ExtensionProcessManager* manager_;
   ExtensionService* service_;
   base::WeakPtr<AutomationProvider> automation_;
   int id_;
+  bool use_json_;

[dennis_jeffrey, 2011/11/22 23:32:16]

nit: Should we move this down below the definition of reply_message_ below, to
separate the variables for constructor arguments from the other class variables?

[kkania, 2011/11/23 17:31:23]

Done.

   scoped_ptr<IPC::Message> reply_message_;
   const Extension* extension_;
 
   DISALLOW_COPY_AND_ASSIGN(ExtensionReadyNotificationObserver);
 };
 
 class ExtensionUnloadNotificationObserver
     : public content::NotificationObserver {
  public:
   ExtensionUnloadNotificationObserver();
@@ skipping 1439 matching lines @@
  private:
   content::NotificationRegistrar registrar_;
   base::WeakPtr<AutomationProvider> automation_;
   scoped_ptr<IPC::Message> reply_message_;
   int new_window_id_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserOpenedWithNewProfileNotificationObserver);
 };
 
 #endif  // CHROME_BROWSER_AUTOMATION_AUTOMATION_PROVIDER_OBSERVERS_H_