Rewrite BufferedDataSource tests to use real BufferedResourceLoader objects.

webkit/media/response_generator.h

+// Copyright (c) 2011 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "base/basictypes.h"
+#include "googleurl/src/gurl.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebURLError.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebURLResponse.h"
+
+namespace webkit_media {
+
+// Generates WebURLErrors and WebURLResponses suitable for testing purposes.

[Ami GONE FROM CHROMIUM, 2011/11/22 22:06:23]

Include "test" in the file & class names?

[scherkus (not reviewing), 2011/11/23 04:22:41]

Done.

+class ResponseGenerator {
+ public:
+  enum Flags {

[Ami GONE FROM CHROMIUM, 2011/11/22 22:06:23]

How about some commentary?

TBH, this whole class feels small enough that it should be in-lined in the test
file, unless you expect to be using this elsewhere shortly.

[scherkus (not reviewing), 2011/11/23 04:22:41]

BufferedResourceLoaderTest has lots of crusty response generation code I'd like
to pull out

+    kNormal = 0,
+    kNoAcceptRanges = 1 << 0,
+    kNoContentRange = 1 << 1,
+    kNoContentLength = 1 << 2,
+  };
+
+  ResponseGenerator(const GURL& gurl, int64 content_length);
+
+  WebKit::WebURLError GenerateError();
+  WebKit::WebURLResponse Generate200();
+  WebKit::WebURLResponse Generate206(int64 first_byte_offset);
+  WebKit::WebURLResponse Generate206(int64 first_byte_offset, Flags flags);
+  WebKit::WebURLResponse Generate404();
+
+  const GURL& gurl() { return gurl_; }
+  int64 content_length() { return content_length_; }
+
+ private:
+  GURL gurl_;
+  int64 content_length_;
+
+  DISALLOW_COPY_AND_ASSIGN(ResponseGenerator);
+};
+
+}  // namespace webkit_media