GTK: Port ui/base/gtk to use avoid deprecated API and accessors

GTK: Port ui/base/gtk to use avoid deprecated API and accessors

New API used:

gtk_widget_{set,get}_has_window - added 2.18 - replaces !GTK_WIDGET_NO_WINDOW
gtk_widget_{set,get}_allocation - added 2.18 - replaces direct access
gtk_bin_get_child - replaces direct access
gtk_widget_get_window - added 2.14 - replaces direct access
g_cclosure_marshal_VOID__BOXED - replaces gtk_marshal_VOID__BOXED

With these changes this directory can compile with GSEAL enabled and
deprecated functions disabled.

BUG=79722
TEST=Compiles and also the ui_unittests pass


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=112027

[robert.bradford, 2011-11-22 18:28:12]

This time with an @intel.com and the wildcard in the AUTHORS file.

[Elliot Glaysher, 2011-11-28 18:47:08]

http://codereview.chromium.org/8646002/diff/1/ui/base/gtk/gtk_expanded_contai...
File ui/base/gtk/gtk_expanded_container_unittest.cc (right):

http://codereview.chromium.org/8646002/diff/1/ui/base/gtk/gtk_expanded_contai...
ui/base/gtk/gtk_expanded_container_unittest.cc:9: #define
EXPECT_ALLOCATION_EQ(widget, x_, y_, width_, height_) \
Please use "do { ..code.. } while(0)" form inside C macros.

[robert.bradford, 2011-11-29 12:25:44]

On 2011/11/28 18:47:08, Elliot Glaysher wrote:
>
http://codereview.chromium.org/8646002/diff/1/ui/base/gtk/gtk_expanded_contai...
> File ui/base/gtk/gtk_expanded_container_unittest.cc (right):
> 
>
http://codereview.chromium.org/8646002/diff/1/ui/base/gtk/gtk_expanded_contai...
> ui/base/gtk/gtk_expanded_container_unittest.cc:9: #define
> EXPECT_ALLOCATION_EQ(widget, x_, y_, width_, height_) \
> Please use "do { ..code.. } while(0)" form inside C macros.

Done.

[robert.bradford, 2011-11-29 12:26:22]

Changes integrated.

[Elliot Glaysher, 2011-11-29 17:34:10]

lgtm

I'm going to land this one first, and wait for it to land before doing the other
to make sure the AUTHORS change sticks.

[commit-bot: I haz the power, 2011-11-29 17:34:24]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8646002/5001

[commit-bot: I haz the power, 2011-11-29 17:34:26]

Can't apply patch for file AUTHORS.
While running patch -p1 --forward --force;
patching file AUTHORS
Hunk #1 FAILED at 143.
1 out of 1 hunk FAILED -- saving rejects to file AUTHORS.rej

[robert.bradford, 2011-11-29 19:10:04]

Elliot, here is an updated change with the AUTHORS file fixed.

[commit-bot: I haz the power, 2011-11-29 19:17:02]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8646002/3003

[commit-bot: I haz the power, 2011-11-29 19:52:35]

Try job failure for 8646002-3003 (retry) on linux_clang for step "compile"
(clobber build).
It's a second try, previously, step "compile" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_clan...

[commit-bot: I haz the power, 2011-11-29 19:54:08]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/robert.bradford@intel.com/8646002/3003

[Elliot Glaysher, 2011-11-29 19:54:19]

(Not your fault, see main waterfall issues. Retrying.)

[commit-bot: I haz the power, 2011-11-29 21:25:43]

Change committed as 112027