Issue 8642006: base::bind migrations for browser.cc

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8642006: base::bind migrations for browser.cc (Closed)

Created:
9 years, 1 month ago by csilv

Modified:
9 years, 1 month ago

Reviewers:
James Hawkins

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

base::bind migrations for browser.cc BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111242

Patch Set 1 #

Total comments: 3

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -14 lines)			Patch
	M	chrome/browser/ui/browser.h	View		3 chunks	+3 lines, -3 lines	1 comment	Download
	M	chrome/browser/ui/browser.cc	View		9 chunks	+12 lines, -11 lines	2 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

James Hawkins

LGTM with nit. http://codereview.chromium.org/8642006/diff/1/chrome/browser/ui/browser.cc File chrome/browser/ui/browser.cc (right): http://codereview.chromium.org/8642006/diff/1/chrome/browser/ui/browser.cc#newcode1740 chrome/browser/ui/browser.cc:1740: FROM_HERE, base::Bind(&Browser::Search, weak_factory_.GetWeakPtr())); This extra space ...

9 years, 1 month ago (2011-11-22 21:26:30 UTC) #2

csilv

9 years, 1 month ago (2011-11-22 21:31:52 UTC) #3

http://codereview.chromium.org/8642006/diff/1/chrome/browser/ui/browser.cc
File chrome/browser/ui/browser.cc (right):

http://codereview.chromium.org/8642006/diff/1/chrome/browser/ui/browser.cc#ne...
chrome/browser/ui/browser.cc:1740: FROM_HERE, base::Bind(&Browser::Search,
weak_factory_.GetWeakPtr()));
On 2011/11/22 21:26:30, James Hawkins wrote:
> This extra space makes the indentation 5 spaces (I think).

Done.

Expand Messages | Collapse Messages