Issue 8642002: Enable FocusManager tests for Aura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8642002: Enable FocusManager tests for Aura. (Closed)

Created:
9 years, 1 month ago by Ben Goodger (Google)

Modified:
9 years, 1 month ago

Reviewers:
sky

CC:
chromium-reviews, tfarina, Paweł Hajdan Jr., dhollowa

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Enable FocusManager tests for Aura. - Now building the file! - Disable some tests that only work on Windows. - Remove some dead Gtk code. http://crbug.com/102572 TEST=unittests Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111220

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 3

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1316 lines, -1339 lines)			Patch
M	ui/views/focus/focus_manager.h	View	1 2	1 chunk	+0 lines, -3 lines	0 comments	Download
M	ui/views/focus/focus_manager.cc	View	1 2	1 chunk	+0 lines, -4 lines	0 comments	Download
A	ui/views/focus/focus_manager_test.h	View	1 2	1 chunk	+75 lines, -0 lines	3 comments	Download
A	ui/views/focus/focus_manager_test.cc	View	1 2	1 chunk	+108 lines, -0 lines	0 comments	Download
M	ui/views/focus/focus_manager_unittest.cc	View	1 2	10 chunks	+31 lines, -1329 lines	0 comments	Download
A	ui/views/focus/focus_manager_unittest_win.cc	View	1 2	1 chunk	+285 lines, -0 lines	0 comments	Download
A	ui/views/focus/focus_traversal_unittest.cc	View	1 2	1 chunk	+812 lines, -0 lines	0 comments	Download
M	ui/views/widget/native_widget_aura.cc	View	1 2	1 chunk	+1 line, -2 lines	0 comments	Download
M	views/views.gyp	View	1 2	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

sky

9 years, 1 month ago (2011-11-22 21:12:38 UTC) #2

LGTM

http://codereview.chromium.org/8642002/diff/1007/ui/views/focus/focus_manager...
File ui/views/focus/focus_manager_test.h (right):

http://codereview.chromium.org/8642002/diff/1007/ui/views/focus/focus_manager...
ui/views/focus/focus_manager_test.h:35: virtual void InitContentView();
Add a description.

http://codereview.chromium.org/8642002/diff/1007/ui/views/focus/focus_manager...
ui/views/focus/focus_manager_test.h:57: class TestFocusChangeListener : public
FocusChangeListener {
Add a description.

http://codereview.chromium.org/8642002/diff/1007/ui/views/focus/focus_manager...
ui/views/focus/focus_manager_test.h:71: };
DISALLOW_COPY_AND_ASSIGN

Expand Messages | Collapse Messages