Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Issue 8642001: Add RunTestWithWebSocketServer for subsequent Pepper WebSocket API tests. (Closed)

Created:
9 years, 1 month ago by Takashi Toyoshima
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Add RunTestWithWebSocketServer for subsequent Pepper WebSocket API tests. BUG=87310 TEST=n/a Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111293

Patch Set 1 : ready for review #

Patch Set 2 : use PathService::Get(chrome::DIR_LAYOUT_TESTS) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -0 lines) Patch
M chrome/test/ui/ppapi_uitest.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Takashi Toyoshima
Hi chrome/test/OWNERS, Could you review this change to add test runner with launching WebSocket server. ...
9 years, 1 month ago (2011-11-22 19:25:18 UTC) #1
sky
LGTM
9 years, 1 month ago (2011-11-22 20:56:49 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8642001/3002
9 years, 1 month ago (2011-11-23 00:38:22 UTC) #3
commit-bot: I haz the power
9 years, 1 month ago (2011-11-23 02:32:57 UTC) #4
Change committed as 111293

Powered by Google App Engine
This is Rietveld 408576698