Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 8641003: Interleave DrMemory's error reports, but disable summaries and startup info. (Closed)

Created:
9 years, 1 month ago by Reid Kleckner (google)
Modified:
9 years, 1 month ago
Reviewers:
Timur Iskhodzhanov
CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org, drmemory-team_google.com
Visibility:
Public.

Description

Interleave DrMemory's error reports, but disable summaries and startup info. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111233

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
M tools/valgrind/valgrind_test.py View 1 chunk +8 lines, -1 line 2 comments Download

Messages

Total messages: 6 (0 generated)
Reid Kleckner (google)
PTAL
9 years, 1 month ago (2011-11-22 17:42:23 UTC) #1
commit-bot: I haz the power
No comments yet.
9 years, 1 month ago (2011-11-22 17:43:19 UTC) #2
Timur Iskhodzhanov
LGTM provided the answer is "yes" http://codereview.chromium.org/8641003/diff/1/tools/valgrind/valgrind_test.py File tools/valgrind/valgrind_test.py (right): http://codereview.chromium.org/8641003/diff/1/tools/valgrind/valgrind_test.py#newcode855 tools/valgrind/valgrind_test.py:855: proc += ["-batch", ...
9 years, 1 month ago (2011-11-22 19:13:59 UTC) #3
Reid Kleckner (google)
OK, let's see if the CQ works for me now... http://codereview.chromium.org/8641003/diff/1/tools/valgrind/valgrind_test.py File tools/valgrind/valgrind_test.py (right): http://codereview.chromium.org/8641003/diff/1/tools/valgrind/valgrind_test.py#newcode855 ...
9 years, 1 month ago (2011-11-22 19:59:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rnk@google.com/8641003/1
9 years, 1 month ago (2011-11-22 20:01:18 UTC) #5
commit-bot: I haz the power
9 years, 1 month ago (2011-11-22 22:17:55 UTC) #6
Change committed as 111233

Powered by Google App Engine
This is Rietveld 408576698