Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(46)

Unified Diff: chrome/browser/extensions/extension_websocket_apitest.cc

Issue 8641002: Add chrome::DIR_LAYOUT_TESTS to PathService::Get (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_websocket_apitest.cc
diff --git a/chrome/browser/extensions/extension_websocket_apitest.cc b/chrome/browser/extensions/extension_websocket_apitest.cc
index a617d04ffa3187220e80f9ad75d4af692b1fdc65..e742dcce797559891aa8a79cd71b11419a4c54ac 100644
--- a/chrome/browser/extensions/extension_websocket_apitest.cc
+++ b/chrome/browser/extensions/extension_websocket_apitest.cc
@@ -10,11 +10,22 @@
// Disabled, http://crbug.com/91058.
IN_PROC_BROWSER_TEST_F(ExtensionApiTest, DISABLED_WebSocket) {
- FilePath websocket_root_dir;
- PathService::Get(chrome::DIR_TEST_DATA, &websocket_root_dir);
- websocket_root_dir = websocket_root_dir.AppendASCII("layout_tests")
- .AppendASCII("LayoutTests");
+ // Gets layout tests root. For the current git workflow, this is
+ // third_party/WebKit/LayoutTests
+ // On svn workflow (including build machines) and older git workflow, this is
+ // chrome/test/data/layout_tests/LayoutTests
+ FilePath webkit_layout_tests;
+ PathService::Get(base::DIR_SOURCE_ROOT, &webkit_layout_tests);
Paweł Hajdan Jr. 2011/11/22 13:48:52 Check the return value, here and below.
Takashi Toyoshima 2011/11/22 13:56:59 Done.
+ webkit_layout_tests = webkit_layout_tests.AppendASCII("third_party");
+ webkit_layout_tests = webkit_layout_tests.AppendASCII("WebKit");
+ webkit_layout_tests = webkit_layout_tests.AppendASCII("LayoutTests");
+ if (!file_util::DirectoryExists(webkit_layout_tests)) {
+ PathService::Get(chrome::DIR_TEST_DATA, &webkit_layout_tests);
+ webkit_layout_tests = webkit_layout_tests.AppendASCII("layout_tests");
+ webkit_layout_tests = webkit_layout_tests.AppendASCII("LayoutTests");
+ }
+
ui_test_utils::TestWebSocketServer server;
- ASSERT_TRUE(server.Start(websocket_root_dir));
+ ASSERT_TRUE(server.Start(webkit_layout_tests));
ASSERT_TRUE(RunExtensionTest("websocket")) << message_;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698