Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(691)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 8638016: Add OVERRIDE to chrome/browser/chromeos/. (Closed)

Created:
9 years, 1 month ago by Avi (use Gerrit)
Modified:
9 years, 1 month ago
Reviewers:
Nico
CC:
chromium-reviews, vrk (LEFT CHROMIUM), nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, mihaip+watch_chromium.org, dcheng, dmazzoni+watch_chromium.org, stevenjb+watch_chromium.org, aboxhall+watch_chromium.org, Erik does not do reviews, acolwell+watch_chromium.org, zork+watch_chromium.org, ihf+watch_chromium.org, ddorwin+watch_chromium.org, fischman+watch_chromium.org, yuzo+watch_chromium.org, annacc+watch_chromium.org, ctguil+watch_chromium.org, scherkus (not reviewing), hclam+watch_chromium.org, hashimoto+watch_chromium.org, davidbarr+watch_chromium.org, Aaron Boodman, dtseng+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Add OVERRIDE to chrome/browser/chromeos/. BUG=104314 TEST=no change Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111216

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+310 lines, -231 lines) Patch
M chrome/browser/chromeos/audio_mixer_alsa.h View 2 chunks +9 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/boot_times_loader.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/brightness_observer.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/cros/network_library.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/customization_document.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/dbus/proxy_resolution_service_provider.h View 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/enterprise_extension_observer.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/frame/browser_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/gview_request_interceptor.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/legacy_window_manager/wm_message_listener.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/locale_change_guard.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/base_login_display_host.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/camera_controller.h View 2 chunks +7 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/captcha_view.h View 3 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/login/client_login_response_handler.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/cookie_fetcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/cryptohome_op.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/eula_screen.h View 2 chunks +10 lines, -9 lines 0 comments Download
M chrome/browser/chromeos/login/existing_user_controller.h View 2 chunks +10 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/help_app_launcher.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/helper.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/html_page_screen.h View 4 chunks +12 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/login/image_downloader.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/issue_response_handler.h View 2 chunks +5 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/login_html_dialog.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/message_bubble.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/network_screen.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/login/ownership_service.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/password_changed_view.h View 2 chunks +3 lines, -2 lines 3 comments Download
M chrome/browser/chromeos/login/registration_screen.h View 4 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/screen_lock_view.h View 2 chunks +8 lines, -7 lines 0 comments Download
M chrome/browser/chromeos/login/signed_settings.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/take_photo_view.h View 2 chunks +4 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/test_attempt_state.h View 2 chunks +9 lines, -8 lines 0 comments Download
M chrome/browser/chromeos/login/textfield_with_margin.h View 3 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/login/update_screen.h View 3 chunks +6 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/login/user_image_loader.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/login/web_page_view.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/webui_screen_locker.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_accessibility_handler.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/wizard_controller.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/low_battery_observer.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/media/media_player.h View 2 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/network_login_observer.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/network_message_observer.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/notifications/balloon_view.h View 3 chunks +13 lines, -10 lines 0 comments Download
M chrome/browser/chromeos/notifications/system_notification.h View 2 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/offline/offline_load_page.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/options/network_config_view.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/options/take_photo_dialog.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/panels/panel_scroller.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/panels/panel_scroller_container.h View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/panels/panel_scroller_header.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/preferences.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/sms_observer.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/status/caps_lock_menu_button.h View 2 chunks +7 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/status/clock_menu_button.h View 2 chunks +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu.h View 2 chunks +29 lines, -26 lines 0 comments Download
M chrome/browser/chromeos/status/input_method_menu_button.h View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/status/power_menu_button.h View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/chromeos/status/status_area_button.h View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/tab_closeable_state_watcher.h View 4 chunks +13 lines, -11 lines 0 comments Download
M chrome/browser/chromeos/upgrade_detector_chromeos.h View 2 chunks +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/views/copy_background.h View 3 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/chromeos/views/dropdown_button.h View 2 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Avi (use Gerrit)
No OWNERS so you get it.
9 years, 1 month ago (2011-11-22 19:39:36 UTC) #1
Nico
9 years, 1 month ago (2011-11-22 20:05:11 UTC) #2 
LGTM with a green linux_chromeos_clang try run.

http://codereview.chromium.org/8638016/diff/1/chrome/browser/chromeos/login/p...
File chrome/browser/chromeos/login/password_changed_view.h (right):

http://codereview.chromium.org/8638016/diff/1/chrome/browser/chromeos/login/p...
chrome/browser/chromeos/login/password_changed_view.h:62: const views::Event&
event)  OVERRIDE;
While you're here, can you remove one space in front of this OVERRIDE?

http://codereview.chromium.org/8638016/diff/1/chrome/browser/chromeos/login/p...
chrome/browser/chromeos/login/password_changed_view.h:66: const views::KeyEvent&
keystroke)  OVERRIDE;
here too

http://codereview.chromium.org/8638016/diff/1/chrome/browser/chromeos/login/p...
chrome/browser/chromeos/login/password_changed_view.h:68: const string16&
new_contents)  OVERRIDE {}
here too

Powered by Google App Engine
This is Rietveld 408576698