Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(572)

Issue 8638012: ARM: Implement code stub for object literal creation. (Closed)

Created:
9 years, 1 month ago by Michael Starzinger
Modified:
9 years, 1 month ago
Reviewers:
Erik Corry
CC:
v8-dev
Visibility:
Public.

Description

ARM: Implement code stub for object literal creation. This just ports r10036 to the ARM codegenerator. Please see the original revision for a detailed description. R=erik.corry@gmail.com Committed: http://code.google.com/p/v8/source/detail?r=10056

Patch Set 1 #

Total comments: 3

Patch Set 2 : Addressed comments by Erik Corry. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -9 lines) Patch
M src/arm/code-stubs-arm.cc View 1 3 chunks +45 lines, -4 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 2 chunks +8 lines, -2 lines 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 chunk +14 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Erik Corry
LGTM http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc#newcode362 src/arm/code-stubs-arm.cc:362: __ cmp(r3, ip); Seems like you could use ...
9 years, 1 month ago (2011-11-23 14:14:15 UTC) #1
Michael Starzinger
9 years, 1 month ago (2011-11-23 15:02:02 UTC) #2
Added new patch set. Landed.

http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc
File src/arm/code-stubs-arm.cc (right):

http://codereview.chromium.org/8638012/diff/1/src/arm/code-stubs-arm.cc#newco...
src/arm/code-stubs-arm.cc:362: __ cmp(r3, ip);
On 2011/11/23 14:14:15, Erik Corry wrote:
> Seems like you could use CompareRoot here.

Done.

Powered by Google App Engine
This is Rietveld 408576698