Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 8638009: Re-enable ExtensionApiTest.WebSocket. (Closed)

Created:
9 years, 1 month ago by Takashi Toyoshima
Modified:
9 years, 1 month ago
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-enable ExtensionApiTest.WebSocket. BUG=91058 TEST=browser_test --gtest_filter="ExtensionApiTest.WebSocket" Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111533

Patch Set 1 #

Patch Set 2 : Use PathService::Get(chrome::DIR_LAYOUT_TESTS) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M chrome/browser/extensions/extension_websocket_apitest.cc View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Takashi Toyoshima
Now all problem is fixed by this last change http://codereview.chromium.org/8633004/ . I'd like to enable ...
9 years, 1 month ago (2011-11-24 01:25:37 UTC) #1
Yoyo Zhou
lgtm
9 years, 1 month ago (2011-11-24 06:00:17 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8638009/2001
9 years, 1 month ago (2011-11-24 06:07:44 UTC) #3
commit-bot: I haz the power
Try job failure for 8638009-2001 (retry) on win_rel for step "browser_tests". It's a second try, ...
9 years, 1 month ago (2011-11-24 07:50:49 UTC) #4
Takashi Toyoshima
It seems not to related to this change. I'll retry.
9 years, 1 month ago (2011-11-24 13:57:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/toyoshim@chromium.org/8638009/2001
9 years, 1 month ago (2011-11-24 13:57:40 UTC) #6
commit-bot: I haz the power
9 years, 1 month ago (2011-11-24 15:49:42 UTC) #7
Change committed as 111533

Powered by Google App Engine
This is Rietveld 408576698