Early create AtExitManager on Android because eraly initialization code on Android needs to acces...

Create AtExitManager early on Android.
The initialization code on Android needs to access AtExitManager before initializing TestEnvironment.

BUG=None
Test=Layout Tests on Android.
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111504

[tony, 2011-11-22 17:28:55]

http://codereview.chromium.org/8638006/diff/4001/webkit/support/webkit_suppor...
File webkit/support/webkit_support.cc (right):

http://codereview.chromium.org/8638006/diff/4001/webkit/support/webkit_suppor...
webkit/support/webkit_support.cc:133: explicit TestEnvironment(bool
unit_test_mode,
Nit: No explicit.

http://codereview.chromium.org/8638006/diff/4001/webkit/support/webkit_suppor...
webkit/support/webkit_support.cc:246: base::AtExitManager* at_exit_manager =
NULL;
Can we just have all ports create the at_exit_manager here and pass it to
TestEnvironment?  Please clearly document that we're passing ownership of
at_exit_manager to TestEnvironment.

[Johnny(Jianning) Ding, 2011-11-23 14:52:16]

http://codereview.chromium.org/8638006/diff/4001/webkit/support/webkit_suppor...
File webkit/support/webkit_support.cc (right):

http://codereview.chromium.org/8638006/diff/4001/webkit/support/webkit_suppor...
webkit/support/webkit_support.cc:133: explicit TestEnvironment(bool
unit_test_mode,
On 2011/11/22 17:28:55, tony wrote:
> Nit: No explicit.

Done.

http://codereview.chromium.org/8638006/diff/4001/webkit/support/webkit_suppor...
webkit/support/webkit_support.cc:246: base::AtExitManager* at_exit_manager =
NULL;
On 2011/11/22 17:28:55, tony wrote:
> Can we just have all ports create the at_exit_manager here and pass it to
> TestEnvironment?  Please clearly document that we're passing ownership of
> at_exit_manager to TestEnvironment.

Done.

[tony, 2011-11-23 18:53:51]

LGTM

[commit-bot: I haz the power, 2011-11-24 03:34:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/jnd@chromium.org/8638006/8001

[commit-bot: I haz the power, 2011-11-24 05:25:22]

Try job failure for 8638006-8001 (retry) on win_rel for step "browser_tests".
It's a second try, previously, steps "browser_tests, ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...