Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Unified Diff: chrome/browser/sync/engine/download_updates_command_unittest.cc

Issue 8638001: [Sync] Made some sync session member functions const (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Constify a few more, sync to head Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/download_updates_command_unittest.cc
diff --git a/chrome/browser/sync/engine/download_updates_command_unittest.cc b/chrome/browser/sync/engine/download_updates_command_unittest.cc
index 3e75d437c582dffb9f094b80e2fe558d1d009cbe..846346a8181a336c28caac1bb2fe11058609475f 100644
--- a/chrome/browser/sync/engine/download_updates_command_unittest.cc
+++ b/chrome/browser/sync/engine/download_updates_command_unittest.cc
@@ -42,68 +42,6 @@ class DownloadUpdatesCommandTest : public SyncerCommandTest {
DISALLOW_COPY_AND_ASSIGN(DownloadUpdatesCommandTest);
};
-TEST_F(DownloadUpdatesCommandTest, SetRequestedTypes) {
- {
- SCOPED_TRACE("Several enabled datatypes, spread out across groups.");
- syncable::ModelTypeBitSet enabled_types;
- enabled_types[syncable::BOOKMARKS] = true;
- enabled_types[syncable::AUTOFILL] = true;
- enabled_types[syncable::PREFERENCES] = true;
- sync_pb::EntitySpecifics get_updates_filter;
- command_.SetRequestedTypes(enabled_types, &get_updates_filter);
- ProtoExtensionValidator<sync_pb::EntitySpecifics> v(get_updates_filter);
- v.ExpectHasExtension(sync_pb::autofill);
- v.ExpectHasExtension(sync_pb::preference);
- v.ExpectHasExtension(sync_pb::bookmark);
- v.ExpectNoOtherFieldsOrExtensions();
- }
-
- {
- SCOPED_TRACE("Top level folders.");
- syncable::ModelTypeBitSet enabled_types;
- enabled_types[syncable::TOP_LEVEL_FOLDER] = true;
- enabled_types[syncable::BOOKMARKS] = true;
- sync_pb::EntitySpecifics get_updates_filter;
- command_.SetRequestedTypes(enabled_types, &get_updates_filter);
- ProtoExtensionValidator<sync_pb::EntitySpecifics> v(get_updates_filter);
- v.ExpectHasExtension(sync_pb::bookmark);
- v.ExpectNoOtherFieldsOrExtensions();
- }
-
- {
- SCOPED_TRACE("Bookmarks only.");
- syncable::ModelTypeBitSet enabled_types;
- enabled_types[syncable::BOOKMARKS] = true;
- sync_pb::EntitySpecifics get_updates_filter;
- command_.SetRequestedTypes(enabled_types, &get_updates_filter);
- ProtoExtensionValidator<sync_pb::EntitySpecifics> v(get_updates_filter);
- v.ExpectHasExtension(sync_pb::bookmark);
- v.ExpectNoOtherFieldsOrExtensions();
- }
-
- {
- SCOPED_TRACE("Autofill only.");
- syncable::ModelTypeBitSet enabled_types;
- enabled_types[syncable::AUTOFILL] = true;
- sync_pb::EntitySpecifics get_updates_filter;
- command_.SetRequestedTypes(enabled_types, &get_updates_filter);
- ProtoExtensionValidator<sync_pb::EntitySpecifics> v(get_updates_filter);
- v.ExpectHasExtension(sync_pb::autofill);
- v.ExpectNoOtherFieldsOrExtensions();
- }
-
- {
- SCOPED_TRACE("Preferences only.");
- syncable::ModelTypeBitSet enabled_types;
- enabled_types[syncable::PREFERENCES] = true;
- sync_pb::EntitySpecifics get_updates_filter;
- command_.SetRequestedTypes(enabled_types, &get_updates_filter);
- ProtoExtensionValidator<sync_pb::EntitySpecifics> v(get_updates_filter);
- v.ExpectHasExtension(sync_pb::preference);
- v.ExpectNoOtherFieldsOrExtensions();
- }
-}
-
TEST_F(DownloadUpdatesCommandTest, ExecuteNoPayloads) {
ConfigureMockServerConnection();
mock_server()->ExpectGetUpdatesRequestTypes(

Powered by Google App Engine
This is Rietveld 408576698