Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Unified Diff: chrome/browser/sync/engine/verify_updates_command_unittest.cc

Issue 8638001: [Sync] Made some sync session member functions const (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix latent bug in StatusController Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/sync/engine/verify_updates_command.cc ('k') | chrome/browser/sync/sessions/session_state.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/engine/verify_updates_command_unittest.cc
diff --git a/chrome/browser/sync/engine/verify_updates_command_unittest.cc b/chrome/browser/sync/engine/verify_updates_command_unittest.cc
index 08fd0282708810f53b701ad414e43c5ab6d43ac6..20aab0172454695e0d5aa7f95a1c876857c93803 100644
--- a/chrome/browser/sync/engine/verify_updates_command_unittest.cc
+++ b/chrome/browser/sync/engine/verify_updates_command_unittest.cc
@@ -81,7 +81,7 @@ TEST_F(VerifyUpdatesCommandTest, AllVerified) {
CreateLocalItem("p1", root, syncable::PREFERENCES);
CreateLocalItem("a1", root, syncable::AUTOFILL);
- GetUpdatesResponse* updates = session()->status_controller()->
+ GetUpdatesResponse* updates = session()->mutable_status_controller()->
mutable_updates_response()->mutable_get_updates();
AddUpdate(updates, "b1", root, syncable::BOOKMARKS);
AddUpdate(updates, "b2", root, syncable::BOOKMARKS);
@@ -90,18 +90,20 @@ TEST_F(VerifyUpdatesCommandTest, AllVerified) {
command_.ExecuteImpl(session());
- StatusController* status = session()->status_controller();
+ StatusController* status = session()->mutable_status_controller();
{
sessions::ScopedModelSafeGroupRestriction r(status, GROUP_UI);
- EXPECT_EQ(3, status->update_progress().VerifiedUpdatesSize());
+ ASSERT_TRUE(status->update_progress());
+ EXPECT_EQ(3, status->update_progress()->VerifiedUpdatesSize());
}
{
sessions::ScopedModelSafeGroupRestriction r(status, GROUP_DB);
- EXPECT_EQ(1, status->update_progress().VerifiedUpdatesSize());
+ ASSERT_TRUE(status->update_progress());
+ EXPECT_EQ(1, status->update_progress()->VerifiedUpdatesSize());
}
{
sessions::ScopedModelSafeGroupRestriction r(status, GROUP_PASSIVE);
- EXPECT_EQ(0, status->update_progress().VerifiedUpdatesSize());
+ EXPECT_FALSE(status->update_progress());
}
}
« no previous file with comments | « chrome/browser/sync/engine/verify_updates_command.cc ('k') | chrome/browser/sync/sessions/session_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698