Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Unified Diff: chrome/browser/sync/engine/resolve_conflicts_command.cc

Issue 8638001: [Sync] Made some sync session member functions const (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix latent bug in StatusController Created 9 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/engine/resolve_conflicts_command.cc
diff --git a/chrome/browser/sync/engine/resolve_conflicts_command.cc b/chrome/browser/sync/engine/resolve_conflicts_command.cc
index a8fcefbc98fa22fe0ba0c7181fc1d9be3ac67b05..7329da90dc481fbeb093111513c461f3df86e957 100644
--- a/chrome/browser/sync/engine/resolve_conflicts_command.cc
+++ b/chrome/browser/sync/engine/resolve_conflicts_command.cc
@@ -5,6 +5,7 @@
#include "chrome/browser/sync/engine/resolve_conflicts_command.h"
#include "chrome/browser/sync/engine/conflict_resolver.h"
+#include "chrome/browser/sync/sessions/session_state.h"
#include "chrome/browser/sync/sessions/sync_session.h"
#include "chrome/browser/sync/syncable/directory_manager.h"
@@ -24,8 +25,12 @@ void ResolveConflictsCommand::ModelChangingExecuteImpl(
session->context()->account_name());
if (!dir.good())
return;
- sessions::StatusController* status = session->status_controller();
- status->update_conflicts_resolved(resolver->ResolveConflicts(dir, status));
+ sessions::StatusController* status = session->mutable_status_controller();
+ const sessions::ConflictProgress* progress = status->conflict_progress();
+ if (!progress)
+ return; // Nothing to do.
+ status->update_conflicts_resolved(
+ resolver->ResolveConflicts(dir, *progress, status));
}
} // namespace browser_sync
« no previous file with comments | « chrome/browser/sync/engine/process_updates_command.cc ('k') | chrome/browser/sync/engine/store_timestamps_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698