Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 8637022: Disk cache: Update the remove/insert data files. (Closed)

Created:
9 years, 1 month ago by rvargas (doing something else)
Modified:
9 years ago
Reviewers:
gavinp
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

Disk cache: Update the remove/insert data files. It's been 2 years and three months since the pointer member of RankingsNode was deprecated. These test files were saved before that. BUG=100125 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111979

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -17 lines) Patch
M net/data/cache_tests/insert_empty1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty1/index View Binary file 0 comments Download
M net/data/cache_tests/insert_empty2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty2/index View Binary file 0 comments Download
M net/data/cache_tests/insert_empty3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_empty3/index View Binary file 0 comments Download
M net/data/cache_tests/insert_load1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_load1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_load1/index View Binary file 0 comments Download
M net/data/cache_tests/insert_load2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_load2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_load2/index View Binary file 0 comments Download
M net/data/cache_tests/insert_one1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_one1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_one1/index View Binary file 0 comments Download
M net/data/cache_tests/insert_one2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_one2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_one2/index View Binary file 0 comments Download
M net/data/cache_tests/insert_one3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/insert_one3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/insert_one3/index View Binary file 0 comments Download
M net/data/cache_tests/remove_head1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_head1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_head1/index View Binary file 0 comments Download
M net/data/cache_tests/remove_head2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_head2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_head2/index View Binary file 0 comments Download
M net/data/cache_tests/remove_head3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_head3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_head3/index View Binary file 0 comments Download
M net/data/cache_tests/remove_head4/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_head4/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_head4/index View Binary file 0 comments Download
M net/data/cache_tests/remove_load1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_load1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_load1/index View Binary file 0 comments Download
M net/data/cache_tests/remove_load2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_load2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_load2/index View Binary file 0 comments Download
M net/data/cache_tests/remove_load3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_load3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_load3/index View Binary file 0 comments Download
M net/data/cache_tests/remove_one1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_one1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_one1/index View Binary file 0 comments Download
M net/data/cache_tests/remove_one2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_one2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_one2/index View Binary file 0 comments Download
M net/data/cache_tests/remove_one3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_one3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_one3/index View Binary file 0 comments Download
M net/data/cache_tests/remove_one4/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_one4/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_one4/index View Binary file 0 comments Download
M net/data/cache_tests/remove_tail1/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail1/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail1/index View Binary file 0 comments Download
M net/data/cache_tests/remove_tail2/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail2/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail2/index View Binary file 0 comments Download
M net/data/cache_tests/remove_tail3/data_0 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail3/data_1 View Binary file 0 comments Download
M net/data/cache_tests/remove_tail3/index View Binary file 0 comments Download
M net/tools/crash_cache/crash_cache.cc View 5 chunks +18 lines, -17 lines 2 comments Download

Messages

Total messages: 5 (0 generated)
rvargas (doing something else)
9 years, 1 month ago (2011-11-22 19:45:07 UTC) #1
gavinp
LGTM! http://codereview.chromium.org/8637022/diff/1/net/tools/crash_cache/crash_cache.cc File net/tools/crash_cache/crash_cache.cc (right): http://codereview.chromium.org/8637022/diff/1/net/tools/crash_cache/crash_cache.cc#newcode143 net/tools/crash_cache/crash_cache.cc:143: } I take it that crash_cache.cc had bitrotted ...
9 years ago (2011-11-28 16:15:00 UTC) #2
rvargas (doing something else)
Thanks http://codereview.chromium.org/8637022/diff/1/net/tools/crash_cache/crash_cache.cc File net/tools/crash_cache/crash_cache.cc (right): http://codereview.chromium.org/8637022/diff/1/net/tools/crash_cache/crash_cache.cc#newcode143 net/tools/crash_cache/crash_cache.cc:143: } On 2011/11/28 16:15:01, gavinp wrote: > I ...
9 years ago (2011-11-28 19:06:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rvargas@chromium.org/8637022/1
9 years ago (2011-11-29 01:32:25 UTC) #4
commit-bot: I haz the power
9 years ago (2011-11-29 01:32:29 UTC) #5
Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 302: Found

Powered by Google App Engine
This is Rietveld 408576698