Issue 8637012: [cros] Fix header bar button appearance on Login screen.

Issue 8637012: [cros] Fix header bar button appearance on Login screen. (Closed)

Created:
9 years, 1 month ago by Ivan Korotkov

Modified:
9 years, 1 month ago

Reviewers:
Nikita (slow)

CC:
chromium-reviews, arv (Not doing code reviews), nkostylev+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

[cros] Fix header bar button appearance on Login screen. BUG=chromium-os:23186 TEST=Manual: 'Shut Down' and 'Add User' buttons on the Login screen should have a visible focus hint. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111143

Patch Set 1 #

Total comments: 2

Patch Set 2 : Move classes from HTML to JS. #

Total comments: 1

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/resources/chromeos/login/header_bar.html	View	1	1 chunk	+4 lines, -4 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Nikita (slow)

http://codereview.chromium.org/8637012/diff/1/chrome/browser/resources/chromeos/login/header_bar.js File chrome/browser/resources/chromeos/login/header_bar.js (right): http://codereview.chromium.org/8637012/diff/1/chrome/browser/resources/chromeos/login/header_bar.js#newcode29 chrome/browser/resources/chromeos/login/header_bar.js:29: // All header bar buttons have custom appearance. Please ...

9 years, 1 month ago (2011-11-22 12:36:12 UTC) #2

Ivan Korotkov

9 years, 1 month ago (2011-11-22 12:43:02 UTC) #3

Nikita (slow)

9 years, 1 month ago (2011-11-22 12:53:03 UTC) #4

lgtm

http://codereview.chromium.org/8637012/diff/2004/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/login/header_bar.html (right):

http://codereview.chromium.org/8637012/diff/2004/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/login/header_bar.html:3: <button
id="shutdown-button" class="custom-appearance" i18n-content="shutDown"></button>
nit: 80 chars limit is defined for html too. Please format this file. Attributes
should not be aligned with other attributes but follow same 4 space indent
policy.

Expand Messages | Collapse Messages