chrome/browser/sync/engine/sync_scheduler.cc - Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/sync_scheduler.cc

Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, add tests Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/engine/process_updates_command.cc ('K') | « chrome/browser/sync/engine/resolve_conflicts_command_unittest.cc ('k') | chrome/browser/sync/engine/verify_updates_command.h » ('j') | chrome/browser/sync/sessions/sync_session.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/engine/sync_scheduler.cc

diff --git a/chrome/browser/sync/engine/sync_scheduler.cc b/chrome/browser/sync/engine/sync_scheduler.cc

index dea4a18f6ddb10d7a8edeb8e3b16df323b279b1a..d1887840f37d7851470b360c3cd0182ff5d4d1e0 100644

--- a/chrome/browser/sync/engine/sync_scheduler.cc

+++ b/chrome/browser/sync/engine/sync_scheduler.cc

@@ -762,7 +762,7 @@ void SyncScheduler::DoSyncSessionJob(const SyncSessionJob& job) {

// and update any disabled or modified entries in the job.

scoped_ptr<SyncSession> session(CreateSyncSession(job.session->source()));

- job.session->RebaseRoutingInfoWithLatest(session.get());

+ job.session->RebaseRoutingInfoWithLatest(*session);

}

SVLOG(2) << "DoSyncSessionJob with "

<< SyncSessionJob::GetPurposeString(job.purpose) << " job";