chrome/browser/sync/engine/process_updates_command.h - Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/process_updates_command.h

Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, add tests Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/engine/apply_updates_command.cc ('K') | « chrome/browser/sync/engine/process_commit_response_command_unittest.cc ('k') | chrome/browser/sync/engine/process_updates_command.cc » ('j') | chrome/browser/sync/engine/process_updates_command.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/engine/process_updates_command.h

diff --git a/chrome/browser/sync/engine/process_updates_command.h b/chrome/browser/sync/engine/process_updates_command.h

index 26e49939debb45a51029ad00612edb61a1a9af53..1f127066cc4ca78f4f48493b4356f589cc7079c3 100644

--- a/chrome/browser/sync/engine/process_updates_command.h

+++ b/chrome/browser/sync/engine/process_updates_command.h

@@ -34,8 +34,12 @@ class ProcessUpdatesCommand : public ModelChangingSyncerCommand {

ProcessUpdatesCommand();

virtual ~ProcessUpdatesCommand();

+ protected:

// ModelChangingSyncerCommand implementation.

- virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session) OVERRIDE;

+ virtual std::set<ModelSafeGroup> GetGroupsToChange(

+ const sessions::SyncSession& session) const OVERRIDE;

+ virtual bool ModelNeutralExecuteImpl(

+ sessions::SyncSession* session) OVERRIDE;

virtual void ModelChangingExecuteImpl(

sessions::SyncSession* session) OVERRIDE;