chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc - Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc

Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, add tests Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/sync/engine/apply_updates_command.cc ('K') | « chrome/browser/sync/engine/build_and_process_conflict_sets_command.h ('k') | chrome/browser/sync/engine/build_and_process_conflict_sets_command_unittest.cc » ('j') | chrome/browser/sync/engine/process_updates_command.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc

diff --git a/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc b/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc

index ed6076e90aa22c79aa11f84615f3b0e81062f870..29023ef45f83cf70a05e5844309a7cd20aaba9ae 100644

--- a/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc

+++ b/chrome/browser/sync/engine/build_and_process_conflict_sets_command.cc

@@ -30,6 +30,11 @@ using std::vector;

BuildAndProcessConflictSetsCommand::BuildAndProcessConflictSetsCommand() {}

BuildAndProcessConflictSetsCommand::~BuildAndProcessConflictSetsCommand() {}

+std::set<ModelSafeGroup> BuildAndProcessConflictSetsCommand::GetGroupsToChange(

+ const sessions::SyncSession& session) const {

+ return session.GetEnabledGroupsWithConflicts();

void BuildAndProcessConflictSetsCommand::ModelChangingExecuteImpl(

SyncSession* session) {

session->mutable_status_controller()->update_conflict_sets_built(