chrome/browser/sync/engine/apply_updates_command.h - Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/sync/engine/apply_updates_command.h

Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address comments, add tests Created 9 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/sync/engine/apply_updates_command.h

diff --git a/chrome/browser/sync/engine/apply_updates_command.h b/chrome/browser/sync/engine/apply_updates_command.h

index a6c9d2b4f8cec302c87b188f4c8925d0c8ca6852..d75754ffb4ca3cc2e418ed956c08d23605ec125c 100644

--- a/chrome/browser/sync/engine/apply_updates_command.h

+++ b/chrome/browser/sync/engine/apply_updates_command.h

@@ -16,7 +16,10 @@ class ApplyUpdatesCommand : public ModelChangingSyncerCommand {

ApplyUpdatesCommand();

virtual ~ApplyUpdatesCommand();

+ protected:

// ModelChangingSyncerCommand implementation.

+ virtual std::set<ModelSafeGroup> GetGroupsToChange(

+ const sessions::SyncSession& session) const OVERRIDE;

virtual void ModelChangingExecuteImpl(

sessions::SyncSession* session) OVERRIDE;

« no previous file with comments | « no previous file | chrome/browser/sync/engine/apply_updates_command.cc » ('j') | chrome/browser/sync/engine/apply_updates_command.cc » ('J')