Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Side by Side Diff: chrome/browser/sync/engine/verify_updates_command.h

Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head, fix windows compile Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_ENGINE_VERIFY_UPDATES_COMMAND_H_ 5 #ifndef CHROME_BROWSER_SYNC_ENGINE_VERIFY_UPDATES_COMMAND_H_
6 #define CHROME_BROWSER_SYNC_ENGINE_VERIFY_UPDATES_COMMAND_H_ 6 #define CHROME_BROWSER_SYNC_ENGINE_VERIFY_UPDATES_COMMAND_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/compiler_specific.h" 10 #include "base/compiler_specific.h"
11 #include "chrome/browser/sync/engine/model_safe_worker.h" 11 #include "chrome/browser/sync/engine/model_safe_worker.h"
12 #include "chrome/browser/sync/engine/model_changing_syncer_command.h" 12 #include "chrome/browser/sync/engine/model_changing_syncer_command.h"
13 #include "chrome/browser/sync/engine/syncproto.h" 13 #include "chrome/browser/sync/engine/syncproto.h"
14 #include "chrome/browser/sync/engine/syncer_types.h" 14 #include "chrome/browser/sync/engine/syncer_types.h"
15 15
16 namespace syncable { 16 namespace syncable {
17 class WriteTransaction; 17 class WriteTransaction;
18 } 18 }
19 19
20 namespace browser_sync { 20 namespace browser_sync {
21 21
22 // Verifies the response from a GetUpdates request. All invalid updates will be 22 // Verifies the response from a GetUpdates request. All invalid updates will be
23 // noted in the SyncSession after this command is executed. 23 // noted in the SyncSession after this command is executed.
24 class VerifyUpdatesCommand : public ModelChangingSyncerCommand { 24 class VerifyUpdatesCommand : public ModelChangingSyncerCommand {
25 public: 25 public:
26 VerifyUpdatesCommand(); 26 VerifyUpdatesCommand();
27 virtual ~VerifyUpdatesCommand(); 27 virtual ~VerifyUpdatesCommand();
28 28
29 // SyncerCommand implementation. 29 protected:
30 // ModelChangingSyncerCommand implementation.
31 virtual bool HasCustomGroupsToChange() const OVERRIDE;
32 virtual std::set<ModelSafeGroup> GetGroupsToChange(
33 const sessions::SyncSession& session) const OVERRIDE;
30 virtual void ModelChangingExecuteImpl( 34 virtual void ModelChangingExecuteImpl(
31 sessions::SyncSession* session) OVERRIDE; 35 sessions::SyncSession* session) OVERRIDE;
32 36
33 private: 37 private:
34 struct VerifyUpdateResult { 38 struct VerifyUpdateResult {
35 VerifyResult value; 39 VerifyResult value;
36 ModelSafeGroup placement; 40 ModelSafeGroup placement;
37 }; 41 };
38 VerifyUpdateResult VerifyUpdate(syncable::WriteTransaction* trans, 42 VerifyUpdateResult VerifyUpdate(syncable::WriteTransaction* trans,
39 const SyncEntity& entry, 43 const SyncEntity& entry,
40 const ModelSafeRoutingInfo& routes); 44 const ModelSafeRoutingInfo& routes);
41 DISALLOW_COPY_AND_ASSIGN(VerifyUpdatesCommand); 45 DISALLOW_COPY_AND_ASSIGN(VerifyUpdatesCommand);
42 }; 46 };
43 47
44 } // namespace browser_sync 48 } // namespace browser_sync
45 49
46 #endif // CHROME_BROWSER_SYNC_ENGINE_VERIFY_UPDATES_COMMAND_H_ 50 #endif // CHROME_BROWSER_SYNC_ENGINE_VERIFY_UPDATES_COMMAND_H_
OLDNEW
« no previous file with comments | « chrome/browser/sync/engine/update_applicator.cc ('k') | chrome/browser/sync/engine/verify_updates_command.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698