Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(17)

Side by Side Diff: chrome/browser/sync/engine/process_updates_command.h

Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head, fix windows compile Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_ 5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_
6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_ 6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_
7 #pragma once 7 #pragma once
8 8
9 #include "base/compiler_specific.h" 9 #include "base/compiler_specific.h"
10 #include "chrome/browser/sync/engine/model_changing_syncer_command.h" 10 #include "chrome/browser/sync/engine/model_changing_syncer_command.h"
(...skipping 16 matching lines...) Expand all
27 // and verified. 27 // and verified.
28 // 28 //
29 // Postconditions - All of the verified SyncEntity data will be copied to 29 // Postconditions - All of the verified SyncEntity data will be copied to
30 // the server fields of the corresponding syncable entries. 30 // the server fields of the corresponding syncable entries.
31 // TODO(tim): This should not be ModelChanging (bug 36592). 31 // TODO(tim): This should not be ModelChanging (bug 36592).
32 class ProcessUpdatesCommand : public ModelChangingSyncerCommand { 32 class ProcessUpdatesCommand : public ModelChangingSyncerCommand {
33 public: 33 public:
34 ProcessUpdatesCommand(); 34 ProcessUpdatesCommand();
35 virtual ~ProcessUpdatesCommand(); 35 virtual ~ProcessUpdatesCommand();
36 36
37 protected:
37 // ModelChangingSyncerCommand implementation. 38 // ModelChangingSyncerCommand implementation.
38 virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session) OVERRIDE; 39 virtual bool HasCustomGroupsToChange() const OVERRIDE;
40 virtual std::set<ModelSafeGroup> GetGroupsToChange(
41 const sessions::SyncSession& session) const OVERRIDE;
42 virtual bool ModelNeutralExecuteImpl(
43 sessions::SyncSession* session) OVERRIDE;
39 virtual void ModelChangingExecuteImpl( 44 virtual void ModelChangingExecuteImpl(
40 sessions::SyncSession* session) OVERRIDE; 45 sessions::SyncSession* session) OVERRIDE;
41 46
42 private: 47 private:
43 ServerUpdateProcessingResult ProcessUpdate( 48 ServerUpdateProcessingResult ProcessUpdate(
44 const syncable::ScopedDirLookup& dir, 49 const syncable::ScopedDirLookup& dir,
45 const sync_pb::SyncEntity& proto_update, 50 const sync_pb::SyncEntity& proto_update,
46 syncable::WriteTransaction* const trans); 51 syncable::WriteTransaction* const trans);
47 DISALLOW_COPY_AND_ASSIGN(ProcessUpdatesCommand); 52 DISALLOW_COPY_AND_ASSIGN(ProcessUpdatesCommand);
48 }; 53 };
49 54
50 } // namespace browser_sync 55 } // namespace browser_sync
51 56
52 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_ 57 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_UPDATES_COMMAND_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698