Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Side by Side Diff: chrome/browser/sync/engine/process_commit_response_command.h

Issue 8637006: [Sync] Make syncer commands avoid posting tasks on threads with no work to do (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Sync to head, fix windows compile Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_COMMIT_RESPONSE_COMMAND_H_ 5 #ifndef CHROME_BROWSER_SYNC_ENGINE_PROCESS_COMMIT_RESPONSE_COMMAND_H_
6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_COMMIT_RESPONSE_COMMAND_H_ 6 #define CHROME_BROWSER_SYNC_ENGINE_PROCESS_COMMIT_RESPONSE_COMMAND_H_
7 #pragma once 7 #pragma once
8 8
9 #include <set> 9 #include <set>
10 #include <string> 10 #include <string>
(...skipping 10 matching lines...) Expand all
21 } 21 }
22 22
23 namespace browser_sync { 23 namespace browser_sync {
24 24
25 class ProcessCommitResponseCommand : public ModelChangingSyncerCommand { 25 class ProcessCommitResponseCommand : public ModelChangingSyncerCommand {
26 public: 26 public:
27 27
28 ProcessCommitResponseCommand(); 28 ProcessCommitResponseCommand();
29 virtual ~ProcessCommitResponseCommand(); 29 virtual ~ProcessCommitResponseCommand();
30 30
31 protected:
31 // ModelChangingSyncerCommand implementation. 32 // ModelChangingSyncerCommand implementation.
32 virtual bool ModelNeutralExecuteImpl(sessions::SyncSession* session) OVERRIDE; 33 virtual bool HasCustomGroupsToChange() const OVERRIDE;
34 virtual std::set<ModelSafeGroup> GetGroupsToChange(
35 const sessions::SyncSession& session) const OVERRIDE;
36 virtual bool ModelNeutralExecuteImpl(
37 sessions::SyncSession* session) OVERRIDE;
33 virtual void ModelChangingExecuteImpl( 38 virtual void ModelChangingExecuteImpl(
34 sessions::SyncSession* session) OVERRIDE; 39 sessions::SyncSession* session) OVERRIDE;
35 40
36 private: 41 private:
37 CommitResponse::ResponseType ProcessSingleCommitResponse( 42 CommitResponse::ResponseType ProcessSingleCommitResponse(
38 syncable::WriteTransaction* trans, 43 syncable::WriteTransaction* trans,
39 const sync_pb::CommitResponse_EntryResponse& pb_commit_response, 44 const sync_pb::CommitResponse_EntryResponse& pb_commit_response,
40 const sync_pb::SyncEntity& pb_committed_entry, 45 const sync_pb::SyncEntity& pb_committed_entry,
41 const syncable::Id& pre_commit_id, 46 const syncable::Id& pre_commit_id,
42 std::set<syncable::Id>* conflicting_new_directory_ids, 47 std::set<syncable::Id>* conflicting_new_directory_ids,
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
88 const std::string& GetResultingPostCommitName( 93 const std::string& GetResultingPostCommitName(
89 const sync_pb::SyncEntity& committed_entry, 94 const sync_pb::SyncEntity& committed_entry,
90 const CommitResponse_EntryResponse& entry_response); 95 const CommitResponse_EntryResponse& entry_response);
91 96
92 DISALLOW_COPY_AND_ASSIGN(ProcessCommitResponseCommand); 97 DISALLOW_COPY_AND_ASSIGN(ProcessCommitResponseCommand);
93 }; 98 };
94 99
95 } // namespace browser_sync 100 } // namespace browser_sync
96 101
97 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_COMMIT_RESPONSE_COMMAND_H_ 102 #endif // CHROME_BROWSER_SYNC_ENGINE_PROCESS_COMMIT_RESPONSE_COMMAND_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698