chrome: dbus: support asynchronous method replies

dbus/test_service.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "dbus/test_service.h"
 
 #include "base/bind.h"
 #include "base/test/test_timeouts.h"
 #include "base/threading/platform_thread.h"
 #include "dbus/bus.h"
@@ skipping 145 matching lines @@
   ++num_methods;
 
   // Just print an error message as we don't want to crash tests.
   // Tests will fail at a call to WaitUntilServiceIsStarted().
   if (num_methods != kNumMethodsToExport) {
     LOG(ERROR) << "The number of methods does not match";
   }
   message_loop->Run();
 }
 
-Response* TestService::Echo(MethodCall* method_call) {
+void TestService::Echo(MethodCall* method_call,
+    dbus::ExportedObject::ResponseSender response_sender) {

[satorux1, 2011/11/22 22:38:17]

vertical align.

[Vince Laviano, 2011/11/22 23:16:22]

Done.

   MessageReader reader(method_call);
   std::string text_message;
-  if (!reader.PopString(&text_message))
-    return NULL;
+  if (!reader.PopString(&text_message)) {
+    response_sender.Run(NULL);
+    return;
+  }
 
   Response* response = Response::FromMethodCall(method_call);
   MessageWriter writer(response);
   writer.AppendString(text_message);
-  return response;
+  response_sender.Run(response);
 }
 
-Response* TestService::SlowEcho(MethodCall* method_call) {
+void TestService::SlowEcho(MethodCall* method_call,
+    dbus::ExportedObject::ResponseSender response_sender) {

[satorux1, 2011/11/22 22:38:17]

ditto.

[Vince Laviano, 2011/11/22 23:16:22]

This one is 82 chars long when vertically aligned. Right-aligned it at 80. 

Some alternatives are: 
- 4 space indent
- break param type and param name onto separate lines
- put "void" return type on a line of its own above the method name to reduce
line length

What do you think?

   base::PlatformThread::Sleep(TestTimeouts::tiny_timeout_ms());
-  return Echo(method_call);
+  Echo(method_call, response_sender);
 }
 
-Response* TestService::BrokenMethod(MethodCall* method_call) {
-  return NULL;
+void TestService::BrokenMethod(MethodCall* method_call,
+    dbus::ExportedObject::ResponseSender response_sender) {

[satorux1, 2011/11/22 22:38:17]

ditto

[Vince Laviano, 2011/11/22 23:16:22]

This one is 86. Right aligned at 80. See above.

+  response_sender.Run(NULL);
 }
 
 }  // namespace dbus