[NTP4] Auto-deletion of empty apps panes.

chrome/browser/resources/ntp4/apps_page.js

Index: chrome/browser/resources/ntp4/apps_page.js
diff --git a/chrome/browser/resources/ntp4/apps_page.js b/chrome/browser/resources/ntp4/apps_page.js
index aff343f09984b9e3874649c2c42460346f41b955..d86fdfd7e6e81ccd51f4c30a44d89a02a76efa1c 100644
--- a/chrome/browser/resources/ntp4/apps_page.js
+++ b/chrome/browser/resources/ntp4/apps_page.js
@@ -24,7 +24,7 @@ cr.define('ntp4', function() {
     MOST_VISITED_PANE: 2,
     BOOKMARKS_PANE: 3,
     OUTSIDE_NTP: 4
-  };
+  }

[Evan Stade, 2011/12/02 00:53:24]

vat is thees

[Dan Beam, 2011/12/02 01:25:11]

Done. (meant to only remove ; from after function decl(){} that don't need it)

   var DRAG_SOURCE_LIMIT = DRAG_SOURCE.OUTSIDE_NTP + 1;
 
   /**
@@ -35,7 +35,7 @@ cr.define('ntp4', function() {
   function AppContextMenu() {
     this.__proto__ = AppContextMenu.prototype;
     this.initialize();
-  };
+  }
   cr.addSingletonGetter(AppContextMenu);
 
   AppContextMenu.prototype = {
@@ -255,17 +255,6 @@ cr.define('ntp4', function() {
     },
 
     /**
-     * Removes the app tile from the page. Should be called after the app has
-     * been uninstalled.
-     */
-    remove: function() {
-      // Unset the ID immediately, because the app is already gone. But leave
-      // the tile on the page as it animates out.
-      this.id = '';
-      this.tile.doRemove();
-    },
-
-    /**
      * Set the URL of the icon from |appData_|. This won't actually show the
      * icon until loadIcon() is called (for performance reasons; we don't want
      * to load icons until we have to).
@@ -559,8 +548,7 @@ cr.define('ntp4', function() {
      */
     removeFromChrome: function() {
       chrome.send('uninstallApp', [this.appData_.id, true]);
-      this.tile.tilePage.removeTile(this.tile, true);
-
+      this.tile.remove(true);
       if (this.currentBubbleShowing_)
         currentBubbleShowing_.hide();
     },
@@ -788,13 +776,13 @@ cr.define('ntp4', function() {
    */
   function launchAppAfterEnable(appId) {
     chrome.send('launchApp', [appId, APP_LAUNCH.NTP_APP_RE_ENABLE]);
-  };
+  }
 
   function appNotificationChanged(id, notification) {
     var app = $(id);
     if (app)  // The app might have been uninstalled.
       app.setupNotification_(notification);
-  };
+  }
 
   return {
     APP_LAUNCH: APP_LAUNCH,