Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Side by Side Diff: chrome/browser/resources/ntp4/new_tab.js

Issue 8637001: [NTP4] Auto-deletion of empty apps panes. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: more fixes and typos from reviewing myself Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 /** 5 /**
6 * @fileoverview New tab page 6 * @fileoverview New tab page
7 * This is the main code for the new tab page used by touch-enabled Chrome 7 * This is the main code for the new tab page used by touch-enabled Chrome
8 * browsers. For now this is still a prototype. 8 * browsers. For now this is still a prototype.
9 */ 9 */
10 10
(...skipping 319 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 chrome.send('loginMessageSeen'); 330 chrome.send('loginMessageSeen');
331 shouldShowLoginBubble = false; 331 shouldShowLoginBubble = false;
332 } else if (loginBubble) { 332 } else if (loginBubble) {
333 loginBubble.reposition(); 333 loginBubble.reposition();
334 } 334 }
335 } 335 }
336 336
337 /** 337 /**
338 * Wrappers to forward the callback to corresponding PageListView member. 338 * Wrappers to forward the callback to corresponding PageListView member.
339 */ 339 */
340 function appAdded(appData, opt_highlight) { 340 function appAdded() {
341 newTabView.appAdded(appData, opt_highlight); 341 return newTabView.appAdded.apply(newTabView, arguments);
342 } 342 }
343 343
344 function appRemoved(appData, isUninstall) { 344 function appRemoved() {
345 newTabView.appRemoved(appData, isUninstall); 345 return newTabView.appRemoved.apply(newTabView, arguments);
346 } 346 }
347 347
348 function appsPrefChangeCallback(data) { 348 function appsPrefChangeCallback() {
349 newTabView.appsPrefChangedCallback(data); 349 return newTabView.appsPrefChangedCallback.apply(newTabView, arguments);
350 }
351
352 function appsReordered() {
353 return newTabView.appsReordered.apply(newTabView, arguments);
350 } 354 }
351 355
352 function enterRearrangeMode() { 356 function enterRearrangeMode() {
353 newTabView.enterRearrangeMode(); 357 return newTabView.enterRearrangeMode.apply(newTabView, arguments);
354 } 358 }
355 359
356 function getAppsCallback(data) { 360 function getAppsCallback() {
357 newTabView.getAppsCallback(data); 361 return newTabView.getAppsCallback.apply(newTabView, arguments);
358 } 362 }
359 363
360 function getAppsPageIndex(page) { 364 function getAppsPageIndex() {
361 return newTabView.getAppsPageIndex(page); 365 return newTabView.getAppsPageIndex.apply(newTabView, arguments);
362 } 366 }
363 367
364 function getCardSlider() { 368 function getCardSlider() {
365 return newTabView.cardSlider; 369 return newTabView.cardSlider;
366 } 370 }
367 371
368 function leaveRearrangeMode(e) { 372 function leaveRearrangeMode() {
369 newTabView.leaveRearrangeMode(e); 373 return newTabView.leaveRearrangeMode.apply(newTabView, arguments);
370 } 374 }
371 375
372 function saveAppPageName(appPage, name) { 376 function saveAppsPageName() {
373 newTabView.saveAppPageName(appPage, name); 377 return newTabView.saveAppsPageName.apply(newTabView, arguments);
374 } 378 }
375 379
376 function setAppToBeHighlighted(appId) { 380 function setAppToBeHighlighted(appId) {
377 newTabView.highlightAppId = appId; 381 newTabView.highlightAppId = appId;
378 } 382 }
379 383
380 // Return an object with all the exports 384 // Return an object with all the exports
381 return { 385 return {
382 appAdded: appAdded, 386 appAdded: appAdded,
383 appRemoved: appRemoved, 387 appRemoved: appRemoved,
384 appsPrefChangeCallback: appsPrefChangeCallback, 388 appsPrefChangeCallback: appsPrefChangeCallback,
389 appsReordered: appsReordered,
385 enterRearrangeMode: enterRearrangeMode, 390 enterRearrangeMode: enterRearrangeMode,
386 getAppsCallback: getAppsCallback, 391 getAppsCallback: getAppsCallback,
387 getAppsPageIndex: getAppsPageIndex, 392 getAppsPageIndex: getAppsPageIndex,
388 getCardSlider: getCardSlider, 393 getCardSlider: getCardSlider,
394 leaveRearrangeMode: leaveRearrangeMode,
389 onLoad: onLoad, 395 onLoad: onLoad,
390 leaveRearrangeMode: leaveRearrangeMode, 396 saveAppsPageName: saveAppsPageName,
391 saveAppPageName: saveAppPageName,
392 setAppToBeHighlighted: setAppToBeHighlighted, 397 setAppToBeHighlighted: setAppToBeHighlighted,
393 setMostVisitedPages: setMostVisitedPages, 398 setMostVisitedPages: setMostVisitedPages,
394 setRecentlyClosedTabs: setRecentlyClosedTabs, 399 setRecentlyClosedTabs: setRecentlyClosedTabs,
395 setStripeColor: setStripeColor, 400 setStripeColor: setStripeColor,
396 showNotification: showNotification, 401 showNotification: showNotification,
397 themeChanged: themeChanged, 402 themeChanged: themeChanged,
398 updateLogin: updateLogin 403 updateLogin: updateLogin
399 }; 404 };
400 }); 405 });
401 406
402 // publish ntp globals 407 // publish ntp globals
403 // TODO(estade): update the content handlers to use ntp namespace instead of 408 // TODO(estade): update the content handlers to use ntp namespace instead of
404 // making these global. 409 // making these global.
405 var getAppsCallback = ntp4.getAppsCallback; 410 var getAppsCallback = ntp4.getAppsCallback;
406 var appsPrefChangeCallback = ntp4.appsPrefChangeCallback; 411 var appsPrefChangeCallback = ntp4.appsPrefChangeCallback;
407 var themeChanged = ntp4.themeChanged; 412 var themeChanged = ntp4.themeChanged;
408 var recentlyClosedTabs = ntp4.setRecentlyClosedTabs; 413 var recentlyClosedTabs = ntp4.setRecentlyClosedTabs;
409 var setMostVisitedPages = ntp4.setMostVisitedPages; 414 var setMostVisitedPages = ntp4.setMostVisitedPages;
410 var updateLogin = ntp4.updateLogin; 415 var updateLogin = ntp4.updateLogin;
411 416
412 document.addEventListener('DOMContentLoaded', ntp4.onLoad); 417 document.addEventListener('DOMContentLoaded', ntp4.onLoad);
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698