[NTP4] Auto-deletion of empty apps panes.

chrome/browser/resources/ntp4/apps_page.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('ntp4', function() {
   'use strict';
 
   var localStrings = new LocalStrings;
 
   var APP_LAUNCH = {
     // The histogram buckets (keep in sync with extension_constants.h).
     NTP_APPS_MAXIMIZED: 0,
     NTP_APPS_COLLAPSED: 1,
     NTP_APPS_MENU: 2,
     NTP_MOST_VISITED: 3,
     NTP_RECENTLY_CLOSED: 4,
     NTP_APP_RE_ENABLE: 16
   };
 
   // Histogram buckets for UMA tracking of where a DnD drop came from.
   var DRAG_SOURCE = {
     SAME_APPS_PANE: 0,
     OTHER_APPS_PANE: 1,
     MOST_VISITED_PANE: 2,
     BOOKMARKS_PANE: 3,
     OUTSIDE_NTP: 4
-  };
+  }

[Evan Stade, 2011/12/02 00:53:24]

vat is thees

[Dan Beam, 2011/12/02 01:25:11]

Done. (meant to only remove ; from after function decl(){} that don't need it)

   var DRAG_SOURCE_LIMIT = DRAG_SOURCE.OUTSIDE_NTP + 1;
 
   /**
    * App context menu. The class is designed to be used as a singleton with
    * the app that is currently showing a context menu stored in this.app_.
    * @constructor
    */
   function AppContextMenu() {
     this.__proto__ = AppContextMenu.prototype;
     this.initialize();
-  };
+  }
   cr.addSingletonGetter(AppContextMenu);
 
   AppContextMenu.prototype = {
     initialize: function() {
       var menu = new cr.ui.Menu;
       cr.ui.decorate(menu, cr.ui.Menu);
       menu.classList.add('app-context-menu');
       this.menu = menu;
 
       this.launch_ = this.appendMenuItem_();
@@ skipping 199 matching lines @@
 
     /**
      * Sets the color of the favicon dominant color bar.
      * @param {string} color The css-parsable value for the color.
      */
     set stripeColor(color) {
       this.querySelector('.color-stripe').style.backgroundColor = color;
     },
 
     /**
-     * Removes the app tile from the page. Should be called after the app has
-     * been uninstalled.
-     */
-    remove: function() {
-      // Unset the ID immediately, because the app is already gone. But leave
-      // the tile on the page as it animates out.
-      this.id = '';
-      this.tile.doRemove();
-    },
-
-    /**
      * Set the URL of the icon from |appData_|. This won't actually show the
      * icon until loadIcon() is called (for performance reasons; we don't want
      * to load icons until we have to).
      */
     setIcon: function() {
       var src = this.useSmallIcon_ ? this.appData_.icon_small :
                                      this.appData_.icon_big;
       if (!this.appData_.enabled ||
           (!this.appData_.offline_enabled && !navigator.onLine)) {
         src += '?grayscale=true';
@@ skipping 273 matching lines @@
      */
     canBeRemoved: function() {
       return this.appData_.can_uninstall;
     },
 
     /**
      * Uninstalls the app after it's been dropped on the trash.
      */
     removeFromChrome: function() {
       chrome.send('uninstallApp', [this.appData_.id, true]);
-      this.tile.tilePage.removeTile(this.tile, true);
-
+      this.tile.remove(true);
       if (this.currentBubbleShowing_)
         currentBubbleShowing_.hide();
     },
 
     /**
      * Called when a drag is starting on the tile. Updates dataTransfer with
      * data for this tile.
      */
     setDragData: function(dataTransfer) {
       dataTransfer.setData('Text', this.appData_.title);
@@ skipping 207 matching lines @@
       store.setAppsPromoData(data);
   };
 
   /**
    * Launches the specified app using the APP_LAUNCH_NTP_APP_RE_ENABLE
    * histogram. This should only be invoked from the AppLauncherHandler.
    * @param {String} appID The ID of the app.
    */
   function launchAppAfterEnable(appId) {
     chrome.send('launchApp', [appId, APP_LAUNCH.NTP_APP_RE_ENABLE]);
-  };
+  }
 
   function appNotificationChanged(id, notification) {
     var app = $(id);
     if (app)  // The app might have been uninstalled.
       app.setupNotification_(notification);
-  };
+  }
 
   return {
     APP_LAUNCH: APP_LAUNCH,
     appNotificationChanged: appNotificationChanged,
     AppsPage: AppsPage,
     launchAppAfterEnable: launchAppAfterEnable,
   };
 });
 
 // TODO(estade): update the content handlers to use ntp namespace instead of
 // making these global.
 var appNotificationChanged = ntp4.appNotificationChanged;
 var launchAppAfterEnable = ntp4.launchAppAfterEnable;