Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: content/browser/renderer_host/render_view_host.cc

Issue 8636023: Make RenderViewHostObserver interface not use a struct from view_messages.h (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: '' Created 9 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/render_view_host.h" 5 #include "content/browser/renderer_host/render_view_host.h"
6 6
7 #include <string> 7 #include <string>
8 #include <utility> 8 #include <utility>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 229 matching lines...) Expand 10 before | Expand all | Expand 10 after
240 // user naivgates even if the renderer is delayed. There is also an issue 240 // user naivgates even if the renderer is delayed. There is also an issue
241 // with the throbber starting because the WebUI (which controls whether the 241 // with the throbber starting because the WebUI (which controls whether the
242 // favicon is displayed) happens synchronously. If the start loading 242 // favicon is displayed) happens synchronously. If the start loading
243 // messages was asynchronous, then the default favicon would flash in. 243 // messages was asynchronous, then the default favicon would flash in.
244 // 244 //
245 // WebKit doesn't send throb notifications for JavaScript URLs, so we 245 // WebKit doesn't send throb notifications for JavaScript URLs, so we
246 // don't want to either. 246 // don't want to either.
247 if (!params.url.SchemeIs(chrome::kJavaScriptScheme)) 247 if (!params.url.SchemeIs(chrome::kJavaScriptScheme))
248 delegate_->DidStartLoading(); 248 delegate_->DidStartLoading();
249 249
250 FOR_EACH_OBSERVER( 250 FOR_EACH_OBSERVER(RenderViewHostObserver, observers_, Navigate(params.url));
251 RenderViewHostObserver, observers_, Navigate(params));
252 } 251 }
253 252
254 void RenderViewHost::NavigateToURL(const GURL& url) { 253 void RenderViewHost::NavigateToURL(const GURL& url) {
255 ViewMsg_Navigate_Params params; 254 ViewMsg_Navigate_Params params;
256 params.page_id = -1; 255 params.page_id = -1;
257 params.pending_history_list_offset = -1; 256 params.pending_history_list_offset = -1;
258 params.current_history_list_offset = -1; 257 params.current_history_list_offset = -1;
259 params.current_history_list_length = 0; 258 params.current_history_list_length = 0;
260 params.url = url; 259 params.url = url;
261 params.transition = content::PAGE_TRANSITION_LINK; 260 params.transition = content::PAGE_TRANSITION_LINK;
(...skipping 1240 matching lines...) Expand 10 before | Expand all | Expand 10 after
1502 1501
1503 void RenderViewHost::OnWebUISend(const GURL& source_url, 1502 void RenderViewHost::OnWebUISend(const GURL& source_url,
1504 const std::string& name, 1503 const std::string& name,
1505 const base::ListValue& args) { 1504 const base::ListValue& args) {
1506 delegate_->WebUISend(this, source_url, name, args); 1505 delegate_->WebUISend(this, source_url, name, args);
1507 } 1506 }
1508 1507
1509 void RenderViewHost::ClearPowerSaveBlockers() { 1508 void RenderViewHost::ClearPowerSaveBlockers() {
1510 STLDeleteValues(&power_save_blockers_); 1509 STLDeleteValues(&power_save_blockers_);
1511 } 1510 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698