Issue 8636020: Remove obsolete UserSettings class

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 8636020: Remove obsolete UserSettings class (Closed)

Created:
9 years, 1 month ago by rlarocque

Modified:
9 years ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews, Raghu Simha, ncarter (slow), akalin, tim (not reviewing), Paweł Hajdan Jr.

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Created: 9 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -882 lines)			Patch
D	chrome/browser/sync/util/user_settings.cc	View	1 chunk	+0 lines, -465 lines	0 comments	Download
D	chrome/browser/sync/util/user_settings_posix.cc	View	1 chunk	+0 lines, -74 lines	0 comments	Download
D	chrome/browser/sync/util/user_settings_unittest.cc	View	1 chunk	+0 lines, -281 lines	0 comments	Download
D	chrome/browser/sync/util/user_settings_win.cc	View	1 chunk	+0 lines, -57 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 4 (0 generated)

rlarocque

While running the sync unit tests, I noticed that the UserSettings tests were sometimes very ...

9 years, 1 month ago (2011-11-23 01:56:29 UTC) #1

tim (not reviewing)

See my 2nd comment in http://codereview.chromium.org/8468023/ LGTM

9 years, 1 month ago (2011-11-23 02:00:57 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rlarocque@chromium.org/8636020/1

9 years ago (2011-11-30 22:01:10 UTC) #3

Change committed as 112342