Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Issue 8636014: Remove useless use of pref from unit test. (Closed)

Created:
9 years ago by Torne
Modified:
9 years ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, Paweł Hajdan Jr.
Visibility:
Public.

Description

Remove useless use of pref from unit test. The unit test doesn't need to try and set this pref, since it's only used by high level UI code to decide what arguments to pass to BrowsingDataRemover::Remove; the unit test always passes explicit things to remove that do not include the LSO store. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111350

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -1 line) Patch
M chrome/browser/browsing_data_remover_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (0 generated)
Torne
Hi Bernhard, Would you mind taking a look at this? This pref set is causing ...
9 years ago (2011-11-22 16:57:36 UTC) #1
Bernhard Bauer
Yes, that might be unnecessary. LGTM and thansk for the cleanup!
9 years ago (2011-11-22 18:48:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/torne@chromium.org/8636014/1
9 years ago (2011-11-23 11:11:12 UTC) #3
commit-bot: I haz the power
9 years ago (2011-11-23 14:01:16 UTC) #4
Change committed as 111350

Powered by Google App Engine
This is Rietveld 408576698