Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 8636008: Update chrome_tests.sh to run DrMemory from Cygwin (Closed)

Created:
9 years ago by Timur Iskhodzhanov
Modified:
9 years ago
CC:
chromium-reviews, pam+watch_chromium.org, stuartmorgan+watch_chromium.org
Visibility:
Public.

Description

Update chrome_tests.sh to run DrMemory from Cygwin Also change valgrind_tests.py to use cygpath to give DrMemory Windows paths when running with Cygwin Python. The original change was made by Reid Kleckner and reviewed at http://codereview.chromium.org/8505028/ TBR=glider Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=111129

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -49 lines) Patch
M tools/valgrind/chrome_tests.sh View 2 chunks +43 lines, -47 lines 0 comments Download
M tools/valgrind/common.py View 1 chunk +21 lines, -0 lines 0 comments Download
M tools/valgrind/valgrind_test.py View 3 chunks +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Timur Iskhodzhanov
9 years ago (2011-11-22 10:35:11 UTC) #1
Timur Iskhodzhanov
TBR
9 years ago (2011-11-22 10:36:08 UTC) #2
Alexander Potapenko
9 years ago (2011-11-22 11:27:10 UTC) #3
On 2011/11/22 10:36:08, Timur Iskhodzhanov wrote:
> TBR

LGTM

Powered by Google App Engine
This is Rietveld 408576698